Prevent Jackson failing while loading Modules (classloader issues) #5604

jansupol · 2024-04-11T08:24:47Z

No description provided.

Signed-off-by: jansupol <jan.supol@oracle.com>

jbescos

Awesome, thanks

jbescos · 2024-04-12T06:10:58Z

This would be nice to be backported in 2.x

jbescos · 2024-04-15T13:04:23Z

...kson/src/main/java/org/glassfish/jersey/jackson/internal/DefaultJacksonJaxbJsonProvider.java

+        final List<Module> modules;
+        try {
+            modules = ObjectMapper.findModules();
+        } catch (Exception e) {


Just I noted that ObjectMapper will throw an java.util.ServiceConfigurationError. This needs to catch Throwable.

pizzi80 · 2024-05-24T11:00:49Z

Which version of the 3.1 line will have this fix?

I've the following exception only on the first request

jakarta.servlet.ServletException: org.glassfish.jersey.server.ContainerException: java.lang.NoClassDefFoundError: com/fasterxml/jackson/module/jaxb/JaxbAnnotationIntrospector
	at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:409)
	at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:195)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:482)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344)
	at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:431)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:896)
	at org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoint.java:1685)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
	at org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoint.java:1248)
	at org.apache.tomcat.util.net.Nio2Endpoint.setSocketOptions(Nio2Endpoint.java:330)
	at org.apache.tomcat.util.net.Nio2Endpoint$Nio2Acceptor.completed(Nio2Endpoint.java:470)
	at org.apache.tomcat.util.net.Nio2Endpoint$Nio2Acceptor.completed(Nio2Endpoint.java:406)
	at java.base/sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:129)
	at java.base/sun.nio.ch.Invoker$2.run(Invoker.java:221)
	at java.base/sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:113)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: org.glassfish.jersey.server.ContainerException: java.lang.NoClassDefFoundError: com/fasterxml/jackson/module/jaxb/JaxbAnnotationIntrospector
	at org.glassfish.jersey.servlet.internal.ResponseWriter.rethrow(ResponseWriter.java:255)
	at org.glassfish.jersey.servlet.internal.ResponseWriter.failure(ResponseWriter.java:237)
	at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:458)
	at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:271)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266)
	at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242)
	at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697)
	at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394)
	... 32 more
Caused by: java.lang.NoClassDefFoundError: com/fasterxml/jackson/module/jaxb/JaxbAnnotationIntrospector
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator._resolveIntrospector(JsonMapperConfigurator.java:111)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator._resolveIntrospectors(JsonMapperConfigurator.java:86)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.cfg.MapperConfiguratorBase._setAnnotations(MapperConfiguratorBase.java:123)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator.getDefaultMapper(JsonMapperConfigurator.java:47)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase.locateMapper(ProviderBase.java:941)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase._endpointForWriting(ProviderBase.java:713)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase.writeTo(ProviderBase.java:588)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:242)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:227)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:85)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:61)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116)
	at org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678)
	at org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387)
	at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377)
	at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266)
	... 41 more
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1332)
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1144)
	... 60 more

jansupol · 2024-05-24T11:03:39Z

@pizzi80 You are lucky as that should be fixed in 3.1.7. It should be out by the end of this week, unless unexpected technical difficulties.

pizzi80 · 2024-05-24T11:06:18Z

Perfect!!

I assumed it was 3.1.7, but just to confirm that this was the bug in question and the related pull request!

thanks for your answer!

senivam · 2024-05-24T20:50:32Z

@pizzi80 3.1.7 is in mvn central.

pizzi80 · 2024-05-27T16:38:33Z

thank you all for the response

Just upgraded to 3.1.7 but the bug it's still present :|

After a server startup, only the very first response that produces json

If you prefer I could open a new issue!

let me know

java.lang.NoClassDefFoundError: com/fasterxml/jackson/module/jaxb/JaxbAnnotationIntrospector
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator._resolveIntrospector(JsonMapperConfigurator.java:111)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator._resolveIntrospectors(JsonMapperConfigurator.java:86)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.cfg.MapperConfiguratorBase._setAnnotations(MapperConfiguratorBase.java:123)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.json.JsonMapperConfigurator.getDefaultMapper(JsonMapperConfigurator.java:47)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase.locateMapper(ProviderBase.java:941)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase._endpointForWriting(ProviderBase.java:713)
	at org.glassfish.jersey.jackson.internal.jackson.jaxrs.base.ProviderBase.writeTo(ProviderBase.java:588)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.invokeWriteTo(WriterInterceptorExecutor.java:242)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor$TerminalWriterInterceptor.aroundWriteTo(WriterInterceptorExecutor.java:227)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.JsonWithPaddingInterceptor.aroundWriteTo(JsonWithPaddingInterceptor.java:85)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:61)
	at org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
	at org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116)
	at org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:691)
	at org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:398)
	at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:388)
	at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:277)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
	at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
	at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266)
	at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:253)
	at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:696)
	at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394)
	at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312)
	at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:195)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:164)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:140)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:482)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:389)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:896)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1741)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
	at java.base/java.lang.VirtualThread.run(VirtualThread.java:309)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.module.jaxb.JaxbAnnotationIntrospector
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1332)
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1144)
	... 50 more

jbescos · 2024-05-28T05:01:37Z

This is other issue. In your stacktrace you should have the class we modified: DefaultJacksonJaxbJsonProvider.java, but I don't see it.

senivam · 2024-05-28T05:18:24Z

you should check if you have

            <groupId>com.fasterxml.jackson.module</groupId>
            <artifactId>jackson-module-jaxb-annotations</artifactId>

dependency on your class path.

pizzi80 · 2024-05-28T09:43:17Z

Excatly, I don't have JAXB at all

I'm using only Weld + Jersey + Jackson

Tomcat 10.1.24
Java 21.0.3

<!-- CDI for Tomcat -->
<dependency>
    <groupId>org.jboss.weld.servlet</groupId>
    <artifactId>weld-servlet-shaded</artifactId>
    <version>5.1.2.Final</version>
</dependency>

<!-- Jandex to speedup Weld -->
<dependency>
    <groupId>io.smallrye</groupId>
    <artifactId>jandex</artifactId>
    <version>3.2.0</version>
</dependency>

<dependency>
    <groupId>org.glassfish.jersey.containers</groupId>
    <artifactId>jersey-container-servlet</artifactId>
    <version>${jersey.version}</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.inject</groupId>
    <artifactId>jersey-hk2</artifactId>
    <version>${jersey.version}</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.ext.cdi</groupId>
    <artifactId>jersey-cdi1x</artifactId>
    <version>${jersey.version}</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.ext.cdi</groupId>
    <artifactId>jersey-cdi1x-servlet</artifactId>
    <version>${jersey.version}</version>
</dependency>
<dependency>
    <groupId>org.glassfish.jersey.media</groupId>
    <artifactId>jersey-media-json-jackson</artifactId>
    <version>${jersey.version}</version>
</dependency>

senivam · 2024-05-28T09:58:59Z

In this case, make sure the JacksonJsonProvider is used. Do not use JacksonJaxbJsonProvider - it provides default annotation for the JAXB usage while the JacksonJsonProvider has only JACKSON annotation.

senivam · 2024-05-28T10:21:20Z

Hm, as I'm looking at how to register only JacksonJsonProvider it might be easier to add the given dependency to the CP. The paradox is that JAXB related annotation modules are disabled by default:

private static final String[] EXCLUDE_MODULE_NAMES = {"JaxbAnnotationModule", "JakartaXmlBindAnnotationModule"};

However, both JACKSON and JAXB annotations are included in the processing flow for compatibility reasons.

pizzi80 · 2024-05-28T11:16:18Z

I've investigated a bit,

inspired by: FasterXML/jackson-future-ideas#11

I've resolved adding the following ContextResolver:

Not sure if it's the best solution

@Provider
@Consumes(MediaType.APPLICATION_JSON)
@Produces(MediaType.APPLICATION_JSON)
public class JsonJacksonOnlyProvider implements ContextResolver<ObjectMapper> {

    private static final ObjectMapper mapper = new ObjectMapper();
    static {
        mapper.setAnnotationIntrospector(new JacksonAnnotationIntrospector());
    }

    @Override
    public ObjectMapper getContext(Class<?> type) {
        return mapper;
    }

}

and I've added some exclusions to pom.xml

<dependency>
    <groupId>org.glassfish.jersey.media</groupId>
    <artifactId>jersey-media-json-jackson</artifactId>
    <version>${jersey.version}</version>
    <exclusions>
        <exclusion>
            <groupId>jakarta.xml.bind</groupId>
            <artifactId>jakarta.xml.bind-api</artifactId>
        </exclusion>
        <exclusion>
            <groupId>com.fasterxml.jackson.module</groupId>
            <artifactId>jackson-module-jakarta-xmlbind-annotations</artifactId>
        </exclusion>
    </exclusions>
</dependency>

senivam · 2024-05-28T11:20:01Z

yes, this line mapper.setAnnotationIntrospector(new JacksonAnnotationIntrospector()); limits Jackson to only JACKSON annotation processing without JAXB annotation, so it does the magic :)

pizzi80 · 2024-05-28T11:32:38Z

Thanks a lot for the support! ;)

Prevent Jackson failing while loading Modules (classloader issues)

41f9300

Signed-off-by: jansupol <jan.supol@oracle.com>

senivam approved these changes Apr 12, 2024

View reviewed changes

jbescos approved these changes Apr 12, 2024

View reviewed changes

senivam merged commit 74781a9 into eclipse-ee4j:2.x Apr 12, 2024
7 checks passed

senivam added this to the 2.43 milestone Apr 12, 2024

jansupol deleted the jackson.load.issue branch April 13, 2024 06:26

jbescos reviewed Apr 15, 2024

View reviewed changes

jbescos mentioned this pull request Apr 15, 2024

ObjectMapper.findModules throws Error #5608

Merged

solrbot mentioned this pull request May 7, 2024

chore(deps): update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v2.45 - autoclosed apache/solr#2212

Closed

1 task

This was referenced May 24, 2024

fix(deps): update dependency org.glassfish.jersey.core:jersey-common to v3 jonkoops/keycloak#182

Closed

Update dependency org.glassfish.jersey.inject:jersey-hk2 to v3 codefreak/codefreak#1072

Open

This was referenced May 25, 2024

Update jersey monorepo to v3 (major) sonamko/MoneyTransferAPI#38

Open

fix(deps): update dependency org.glassfish.jersey.media:jersey-media-multipart to v3 ptuomola/fineract#19

Open

renovate bot mentioned this pull request Jun 1, 2024

chore(deps): update jersey monorepo to v2.43 hantsy/jakartaee8-starter-boilerplate#322

Merged

1 task

renovate-bot mentioned this pull request Jun 11, 2024

Update jersey.version to v2.45 - autoclosed xwiki/xwiki-platform#3192

Closed

1 task

renovate bot mentioned this pull request Jul 22, 2024

fix(deps): update dependency org.glassfish.jersey.core:jersey-client to v2.46 Cantara/IoT-frontend#263

Open

1 task

solrbot mentioned this pull request Jul 22, 2024

chore(deps): update dependency org.glassfish.jersey.containers:jersey-container-jetty-http to v3 - autoclosed apache/solr#2582

Closed

1 task

This was referenced Jul 22, 2024

Update jersey monorepo to v2.46 lifs-tools/jmzTab-m-webapp#39

Open

Update jersey monorepo to v2.45 bjorncs/vespa#85

Open

renovate bot mentioned this pull request Sep 29, 2024

Update jersey monorepo to v3 (major) bjorncs/vespa#126

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent Jackson failing while loading Modules (classloader issues) #5604

Prevent Jackson failing while loading Modules (classloader issues) #5604

jansupol commented Apr 11, 2024

jbescos left a comment

jbescos commented Apr 12, 2024

jbescos Apr 15, 2024

pizzi80 commented May 24, 2024

jansupol commented May 24, 2024

pizzi80 commented May 24, 2024

senivam commented May 24, 2024

pizzi80 commented May 27, 2024 •

edited

Loading

jbescos commented May 28, 2024

senivam commented May 28, 2024

pizzi80 commented May 28, 2024

senivam commented May 28, 2024

senivam commented May 28, 2024

pizzi80 commented May 28, 2024 •

edited

Loading

senivam commented May 28, 2024

pizzi80 commented May 28, 2024

Prevent Jackson failing while loading Modules (classloader issues) #5604

Prevent Jackson failing while loading Modules (classloader issues) #5604

Conversation

jansupol commented Apr 11, 2024

jbescos left a comment

Choose a reason for hiding this comment

jbescos commented Apr 12, 2024

jbescos Apr 15, 2024

Choose a reason for hiding this comment

pizzi80 commented May 24, 2024

jansupol commented May 24, 2024

pizzi80 commented May 24, 2024

senivam commented May 24, 2024

pizzi80 commented May 27, 2024 • edited Loading

jbescos commented May 28, 2024

senivam commented May 28, 2024

pizzi80 commented May 28, 2024

senivam commented May 28, 2024

senivam commented May 28, 2024

pizzi80 commented May 28, 2024 • edited Loading

senivam commented May 28, 2024

pizzi80 commented May 28, 2024

pizzi80 commented May 27, 2024 •

edited

Loading

pizzi80 commented May 28, 2024 •

edited

Loading