Skip to content

Conversation

@lbihanic
Copy link

Fixed issue where FirstByteCachingStream fails to include the buffered byte in returned data length when reading with array.

When the problem occurred, the returned length was 1 byte less than the actual array content and the consumer failed to "see" the whole response data. Detected through Jackson parse error reporting missing closing '}'.

…lude the buffered byte in returned data length when reading with array
@senivam
Copy link
Contributor

senivam commented Mar 25, 2025

for me it looks good, thanks, however you should update the copyright year in both files (change the last year to the 2025 in the first file and add , 2025 to the test file) and sign the ECA. Then as for me, I would approve the PR. Thank you for contributing.

@lbihanic
Copy link
Author

Copyright years updated, Eclipse account created and ECA signed :-)

@senivam
Copy link
Contributor

senivam commented Mar 26, 2025

it looks better and better, thank you! The copyright years are fixed, thanks a lot. The ECA is still not recognized. Could you please check the Git ECA validation status page for this PR and follow the troubleshooting guide to see what could possibly be wrong with it? On the same page, you can re-validate the ECA for the PR. If it's required (for the ECA validation), you can amend existing commits and force push them back into the PR branch to fix the ECA issue. But I hope it will be easier to solve. Thanks a lot!

@lbihanic lbihanic force-pushed the jnh-length-error-fix branch from 5380e95 to 2fca287 Compare March 27, 2025 09:43
@senivam senivam merged commit dc4b043 into eclipse-ee4j:3.1 Mar 31, 2025
7 checks passed
@senivam senivam added this to the 3.1.11 milestone Mar 31, 2025
This was referenced Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants