Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParseConfigResourceToDOMTask for https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd (for Jakarta EE 9). #4725

Closed
scottmarlow opened this issue Jun 15, 2020 · 6 comments
Assignees
Milestone

Comments

@scottmarlow
Copy link
Member

Please add https://jakarta.ee/xml/ns/jakartaee/web-facesconfig_3_0.xsd support to Mojarra.

As @smillidge mentioned on the Platform TCK ml, it looks like ParseConfigResourceToDOMTask.java#L224 needs to allow the 3.0 schema. The code change, should be consumed by GlassFish 6.0.

This should help address a Jakarta EE 9 Platform TCK failure with to jsf/spec/render/secret/faces-config.xml.

The test exception is shown here.

CC @arjantijms

@arjantijms
Copy link
Contributor

Thanks Scott, I'm on it. I'll take a look at this first thing tomorrow.

@arjantijms arjantijms self-assigned this Jun 15, 2020
@arjantijms arjantijms added this to the 3.0.0 milestone Jun 15, 2020
@tandraschko
Copy link
Contributor

@arjantijms
We also need to make a facelet-taglib 3.0 with jakarta namespace, right?

@gerdogdu
Copy link
Contributor

@scottmarlow @arjantijms I have add PR for this for 3.0 branch. Now, TCK tests are running succesfully. Here is the PR, #4726

@scottmarlow
Copy link
Member Author

Thanks @gerdogdu!

@scottmarlow
Copy link
Member Author

Closed since the pr is merged.

@alwin-joseph
Copy link

Just for clarification, @gerdogdu @arjantijms Can you please help confirm if all the references of http://xmlns.jcp.org/xml/ns/javaee has been replaced with the latest https://jakarta.ee/xml/ns/jakartaee/.
I found the old schema referenced in below files and some others:
./impl/src/main/resources/com/sun/faces/facelets1_0-2_0toSchema.xsl
./impl/src/main/resources/com/sun/faces/metadata/taglib/jstl-fn.taglib.xml
./impl/src/main/resources/com/sun/faces/metadata/taglib/html_basic.taglib.xml
./impl/src/main/resources/META-INF/mojarra_ext.taglib.xml

I found 8 test failures in jsf tck when the remaining old schema references were replaced using jakartaee/platform-tck#481 , and wanted to confirm if anything more is pending here. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants