Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More schema updates to jakartaee required #4737

Closed
alwin-joseph opened this issue Sep 4, 2020 · 8 comments
Closed

More schema updates to jakartaee required #4737

alwin-joseph opened this issue Sep 4, 2020 · 8 comments
Labels

Comments

@alwin-joseph
Copy link

This issue should be in continuation with #4725

There are more references of javaee xsds in
./impl/src/main/resources/com/sun/faces/facelets1_0-2_0toSchema.xsl
./impl/src/main/resources/com/sun/faces/metadata/taglib/jstl-fn.taglib.xml
./impl/src/main/resources/com/sun/faces/metadata/taglib/html_basic.taglib.xml
./impl/src/main/resources/META-INF/mojarra_ext.taglib.xml

After the jsf TCK was updated using PR jakartaee/platform-tck#481 we encounter 8 test failures as in https://ci.eclipse.org/jakartaee-tck/job/eftl-standalonetck-build-run-900/60.

cc @scottmarlow @gurunrao @arjantijms

@smillidge
Copy link

I'll need a new RC for integrating into GlassFish

@arjantijms
Copy link
Contributor

@smillidge Okay, I'll look at a new RC, and will also stage the Faces API with the latest dependencies update.

There's currently an error in the Mojarra 3.0 (complaint about unknown version), so I have to take look what's causing that.

@alwin-joseph
Copy link
Author

alwin-joseph commented Sep 23, 2020

@arjantijms Is the new RC scheduled to be released yet ? So @smillidge can integrate it to glassfish ?

@arjantijms
Copy link
Contributor

arjantijms commented Sep 26, 2020

@arjantijms Is the new RC scheduled to be released yet ? So @smillidge can integrate it to glassfish ?

There were multiple issues with RC3. One issue was related to an internal config file having the wrong namespace. I looked at this several times but just missed it, my apologies for that. I finally found it after debugging into the very depth of the thing.

Another issue had to do with CDI activation and the 2.3 and pre-2.3 version in the faces-config file that was used for this before. With all config files updated to 3.0, some tests were breaking because of this. I staged -RC4 and I'm now running the TCK against it. So far it looks good, but it's only half-way at the time of writing.

@mnriem mnriem added the 3.0 label Nov 27, 2021
@mnriem
Copy link
Contributor

mnriem commented Feb 28, 2022

@alwin-joseph Can you supply a fix?

@alwin-joseph
Copy link
Author

alwin-joseph commented Mar 2, 2022

@alwin-joseph Can you supply a fix?

Fix in mojarra or tck ?

Actually this issue was created for JakartaEE 9 for which fix was made using PR4738 but now the schemas may need to be updated with JakartaEE 10 namespaces. Were you asking to do similar schema update in mojarra for JakartaEE 10 ?

BTW There are xsds missing in https://jakarta.ee/xml/ns/jakartaee/#10 , eg: web-facelettaglibrary*.xsd. (They may need to be added https://github.com/jakartaee/jakarta.ee/tree/src/static/xml/ns/jakartaee)

@mnriem
Copy link
Contributor

mnriem commented Sep 15, 2023

@arjantijms Has this been resolved? @alwin-joseph If not can you supply a PR that fixes the issues you have found?

@BalusC
Copy link
Contributor

BalusC commented Sep 16, 2024

Closing off as stale.

@BalusC BalusC closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants