Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4431] NPE in ELFlash.get() on first request #4823

Merged
merged 1 commit into from
Mar 27, 2021
Merged

[#4431] NPE in ELFlash.get() on first request #4823

merged 1 commit into from
Mar 27, 2021

Conversation

spyrkob
Copy link
Contributor

@spyrkob spyrkob commented Jan 4, 2021

backport of #4432 for 2.3 branch

@spyrkob
[eclipse-ee4j#4431] NPE in ELFlash.get() on first request
0be3ea4 
Signed-off-by: Bartosz Spyrko-Smietanko <spyrkob@gmail.com>
@spyrkob spyrkob mentioned this pull request Jan 4, 2021
Merged
manorrock
manorrock approved these changes Feb 6, 2021
View reviewed changes
Copy link
Contributor

@manorrock manorrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a patch without a test I am requesting another reviewer to have a look at it

@manorrock manorrock requested review from arjantijms and BalusC and removed request for mnriem and manfredriem February 6, 2021 19:53
@arjantijms
Copy link
Contributor

Thanks for this! If we ever have time (one can dream), we may wanna try to find out why SessionHelper is null in the first place.

@arjantijms arjantijms merged commit 0312a0e into eclipse-ee4j:2.3 Mar 27, 2021
@arjantijms arjantijms added this to the 2.3.15 milestone May 3, 2021
@manorrock manorrock removed their assignment Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manorrock manorrock manorrock approved these changes

@arjantijms arjantijms arjantijms approved these changes

@BalusC BalusC Awaiting requested review from BalusC

Assignees

@manfredriem manfredriem

Labels
None yet
Projects
None yet
Milestone
2.3.15
Development

Successfully merging this pull request may close these issues.
4 participants
@spyrkob @arjantijms @manorrock @manfredriem