Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring dead code back to life #494

Merged
merged 1 commit into from
May 8, 2020
Merged

Bring dead code back to life #494

merged 1 commit into from
May 8, 2020

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Mar 4, 2020

Replacement for #448

@pzygielo pzygielo marked this pull request as ready for review March 4, 2020 11:31
@pzygielo pzygielo closed this Apr 11, 2020
@pzygielo pzygielo deleted the dead branch April 11, 2020 19:45
@pzygielo pzygielo restored the dead branch April 15, 2020 06:45
@pzygielo
Bring dead code back to life
4143b59 
Signed-off-by: Piotrek Zygielo <piotr@zygielo.pl>
@pzygielo pzygielo reopened this Apr 15, 2020
@pzygielo pzygielo marked this pull request as draft April 15, 2020 06:47
@pzygielo pzygielo marked this pull request as ready for review April 15, 2020 07:04
@pzygielo
Copy link
Contributor Author

pzygielo commented May 8, 2020

Is there anything I could do to have it reviewed?

arjantijms
arjantijms approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay and what the original code intended to happen.

@arjantijms arjantijms merged commit 8ba2b9a into eclipse-ee4j:master May 8, 2020
@pzygielo pzygielo deleted the dead branch May 9, 2020 06:22
@pzygielo pzygielo added this to the 6.0.0 milestone Nov 11, 2020
@pzygielo pzygielo mentioned this pull request Jan 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pzygielo @arjantijms