Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UTF-32 charset should fail only in case UTF-32 is detected #121

Closed
danielkec opened this issue Jan 17, 2024 · 2 comments · Fixed by #122
Closed

Missing UTF-32 charset should fail only in case UTF-32 is detected #121

danielkec opened this issue Jan 17, 2024 · 2 comments · Fixed by #122

Comments

@danielkec
Copy link
Contributor

Right now UTF-32 chaset is looked up for unicode version detection during class initialization, no matter whether there will be ever any use of it:

class UnicodeDetectingInputStream extends FilterInputStream {
private static final Charset UTF_32LE = Charset.forName("UTF-32LE");
private static final Charset UTF_32BE = Charset.forName("UTF-32BE");

Actual lookup should be done lazily when UTF-32 is actually detected to support runtimes without UTF-32, like GraalVM native image oracle/graal/issues/1294

@Captain1653
Copy link

Captain1653 commented Apr 5, 2024

@lukasj This issue was fixed in January, but wasn't released as I can see. Is it possible to create the new version with this fix?

@lukasj
Copy link
Member

lukasj commented Apr 5, 2024

@Captain1653 if you have a question, use new issue/mail/discussion post for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants