Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API V2: Add support for "Copy" and "Move" operations #179

Open
CamilleLetavernier opened this issue Mar 3, 2022 · 0 comments
Open

API V2: Add support for "Copy" and "Move" operations #179

CamilleLetavernier opened this issue Mar 3, 2022 · 0 comments
Labels
enhancement New feature or request modelserver EMF.cloud Model Server v2

Comments

@CamilleLetavernier
Copy link
Member

In the current implementation of the V2 API, we support the following operations:

  • Replace
  • Add
  • Remove

Json Patch also defines "Move" and "Copy" Operations, which are currently not handled by the server. We didn't consider them to be useful for a first iteration, as all operations can be defined by composing Replace, Add and Remove operations. However, since we now support pure Json patches, which can be generated by comparing 2 versions of a Json Node using a 3rd party library, the json-patch library might use these Move and Copy operations instead of lower-level Add/Remove operations. This wouldn't work with the current Model Server implementation.

We should add support in the AbstractJsonPatchHelper for Move and Copy operations (Translating them to the corresponding EMF Commands).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modelserver EMF.cloud Model Server v2
Projects
None yet
Development

No branches or pull requests

2 participants