Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING is outdated #54

Closed
cmorty opened this issue Jun 21, 2022 · 0 comments · Fixed by #63
Closed

CONTRIBUTING is outdated #54

cmorty opened this issue Jun 21, 2022 · 0 comments · Fixed by #63

Comments

@cmorty
Copy link
Contributor

cmorty commented Jun 21, 2022

It still refers to the eclipse-site, not github & Co.
https://github.com/eclipse-equinox/equinox/blob/master/CONTRIBUTING

akurtakov added a commit to akurtakov/equinox that referenced this issue Jun 24, 2022
akurtakov added a commit to akurtakov/equinox that referenced this issue Jun 24, 2022
akurtakov added a commit that referenced this issue Jun 24, 2022
laeubi pushed a commit to laeubi/equinox that referenced this issue Jan 19, 2023
…se-equinox#54)

* Avoid use of SecureRandom for creating temporary files

File.createTempFile uses SecureRandom under the covers to generate
unique file names.  This may be important for when storing files in the
global temporary file space to avoid something guessing the file and
writing to it.

The usage in the framework for createTempFile is always used for staging
file content before it gets (reliably) moved to its final destination.
This always happens as an implementation detail of storing some state in
the internal file storage of the framework.  Risk is low that some
malicious code would be able to predict the temporary file and somehow
interfere with the behavior of the framework.  Once some malicious code
has had access to the internal storage of the framework they will be
able to write to other files that have very predictable names to cause
issues.

* Limit retry attempts to MAX_TEMP_NUM (100000)

If we really have this many temporary files
there is something wrong that needs to be addressed.
Fail with IOException if we detect a 100000 attempts
to find a non-existing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant