Remove no longer required annotations.jar

[laeubi]

No description provided.

[tjwatson]

Why not delete the other two instances of this JAR also?

org.eclipse.equinox.http.servlet/osgi/osgi.annotation.jar
org.eclipse.osgi.services/lib/osgi.annotation.jar

[laeubi]

Why not delete the other two instances of this JAR also?

Done!

[github-actions]

Unit Test Results

     24 files       24 suites   11m 32s ⏱️
2 138 tests 2 094 ✔️ 44 💤 0 ❌
2 182 runs  2 138 ✔️ 44 💤 0 ❌

Results for commit 3039b1e.

[tjwatson]

LGTM

[iloveeclipse]

Looks like this caused now releng errors: https://download.eclipse.org/eclipse/downloads/drops4/I20221006-1800/testresults/html/org.eclipse.releng.tests_ep426I-unit-win32-java11_win32.win32.x86_64_11.html

https://download.eclipse.org/eclipse/downloads/drops4/I20221006-1800/compilelogs/platform.doc.isv.javadoc.txt

../../../equinox/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/ExtendedHttpService.java:20: error: package org.osgi.annotation.versioning does not exist
import org.osgi.annotation.versioning.ProviderType;
                                     ^
../../../equinox/bundles/org.eclipse.equinox.http.servlet/src/org/eclipse/equinox/http/servlet/ExtendedHttpService.java:27: error: cannot find symbol
@ProviderType
 ^
  symbol: class ProviderType
2 errors

[laeubi]

How can one test this? It seems https://github.com/eclipse-platform/eclipse.platform.common has no verification builds :-\

Essentially I think the isv builds need to always include the following (just for demonstration, not valid ISV build syntax most probably!):

<additionalDependencies>
	<additionalDependency>
		<groupId>org.osgi</groupId>
		<artifactId>org.osgi.annotation.bundle</artifactId>
		<version>2.0.0</version>
	</additionalDependency>
	<additionalDependency>
		<groupId>org.osgi</groupId>
		<artifactId>org.osgi.annotation.versioning</artifactId>
		<version>1.1.2</version>
	</additionalDependency>
	<additionalDependency>
		<groupId>org.osgi</groupId>
		<artifactId>org.osgi.service.component.annotations</artifactId>
		<version>1.5.0</version>
	</additionalDependency>
</additionalDependencies>

[akurtakov]

The way I test it:

• checkout https://github.com/eclipse-platform/eclipse.platform.releng.aggregator
• cd eclipse.platform.common/bundles/org.eclipse.platform.doc.isv
• mvn clean verify
• look at the build output as the javadoc ant part will not make maven build fail but will have smth like "Javadoc result: 1" and non empty target/doc.bin.log file

[akurtakov]

I'm working on a fix