Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark deprecated methods for removal #734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 31, 2024

No description provided.

Copy link

github-actions bot commented Dec 31, 2024

Test Results

0 files   -   663  0 suites   - 663   0s ⏱️ - 1h 14m 43s
0 tests  - 2 211  0 ✅  - 2 164  0 💤  -  47  0 ❌ ±0 
0 runs   - 6 777  0 ✅  - 6 634  0 💤  - 143  0 ❌ ±0 

Results for commit 2e0e6e6. ± Comparison against base commit 91eebf3.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the mark_deprecated_for_removal branch from eddcbc6 to 2e0e6e6 Compare December 31, 2024 12:11
@laeubi
Copy link
Member Author

laeubi commented Dec 31, 2024

We can't use since / forRemoval here due to java 1.8 compatibility. @tjwatson since this is deprecated since ages (somewhere back to 2006 if I look at the git history) should we probably just remote them without further notice?

@tjwatson
Copy link
Contributor

tjwatson commented Jan 2, 2025

We can't use since / forRemoval here due to java 1.8 compatibility. @tjwatson since this is deprecated since ages (somewhere back to 2006 if I look at the git history) should we probably just remote them without further notice?

I'm not that motivated to remove individual methods from what I consider a completely deprecated package.

@laeubi
Copy link
Member Author

laeubi commented Jan 5, 2025

I'm not that motivated to remove individual methods from what I consider a completely deprecated package.

Maybe we should then add the new deprecated directive to that package? I assumed until now that only the implementation (that already resides in a fragment) is deprecated but not the API itself (what is used in P2 and PDE...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants