Enhance ProgressMonitor usage in ProvisioningContext #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HannesWell
commented
Sep 2, 2023
HannesWell
commented
- Use SubMonitor.split() over newChild()
- Remove explicit checks for cancellation since SubMonitor.split() does that implicitly
- Simplify work computation by avoiding unnecessary multiplies When creating a split SubMonitor the splitted child only operates on the assigned amount of work.
HannesWell
force-pushed
the
monitorInProvContext
branch
3 times, most recently
from
c5ca425
to
33c30a4
Compare
- Use SubMonitor.split() over newChild() - Remove explicit checks for cancellation since SubMonitor.split() does that implicitly - Simplify work computation by avoiding unnecessary multiplies When creating a split SubMonitor the splitted child only operates on the assigned amount of work.
HannesWell
force-pushed
the
monitorInProvContext
branch
from
33c30a4
to
191e622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.