-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete code of abandoned p2 plug-ins #49
Conversation
Would be nice to finish this one. Deletion is always good. :-) |
I'm just waiting for approval for this one, because I don't have a deep insight into p2 if any of those projects could be useful one day. Especially for Maybe someone can judge? @tjwatson, @akurtakov, @mickaelistria, @laeubi? |
I have no clue what these are about, but if they are not build or published I think no one uses them and source control systems are made for the case you later want to go back, so even if someone is later missing this it could be restored and/or migrated to an appropriate place. |
+1, just delete if someone misses them, we can restore |
78363e8
to
22364d8
Compare
Sure it can be reverted if they are again needed later. Nevertheless I wanted to ask just in case I oversaw something. But since no one objected I will submit this after the build had succeeded. :) The removed projects are now listed in the commit message to easier find them if one later searches the git history. |
This affects the following projects: - org.eclipse.equinox.p2.artifact.checksums.bouncycastle - org.eclipse.equinox.p2.artifact.optimizers - org.eclipse.equinox.p2.artifact.processors - org.eclipse.equinox.p2.sar - org.eclipse.equinox.p2.tests.optimizers - org.eclipse.equinox.p2.testserver
22364d8
to
a36c279
Compare
The root .project file of p2 is removed via eclipse-equinox/p2#149 The abandoned project 'org.eclipse.equinox.p2.testserver' has been deleted as part of eclipse-equinox/p2#49
The root .project file of p2 is removed via eclipse-equinox/p2#149 The abandoned project 'org.eclipse.equinox.p2.testserver' has been deleted as part of eclipse-equinox/p2#49
Like in eclipse-equinox/equinox.bundles#17 I want to propose to delete the code of the following p2 plug-ins that are not build and published anymore (I don't know since when):
org.eclipse.equinox.p2.artifact.checksums.bouncycastle
org.eclipse.equinox.p2.artifact.optimizers
org.eclipse.equinox.p2.artifact.processors
org.eclipse.equinox.p2.sar
org.eclipse.equinox.p2.tests.optimizers
org.eclipse.equinox.p2.testserver
If any project is still relevant I suggest to include it in the Jenkins build again to ensure it continues to function (or at least compiles).