Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running SDK and samm-cli on non-GraalVM-JDK #464

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Allow running SDK and samm-cli on non-GraalVM-JDK #464

merged 5 commits into from
Oct 24, 2023

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Oct 23, 2023

Fixes #460

Yauhenikapl
Yauhenikapl approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@atextor atextor merged commit 5902d8f into eclipse-esmf:main Oct 24, 2023
@atextor atextor deleted the 460-does-not-work-on-temurin branch October 24, 2023 04:52
@github-actions
Copy link

Release v2.4.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysrbo ysrbo ysrbo approved these changes

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] samm-cli validate does not work with Temurin
3 participants
@atextor @ysrbo @Yauhenikapl