Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Model information to the Openapi Spec #539

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Add Model information to the Openapi Spec #539

merged 3 commits into from
Mar 13, 2024

Conversation

Yauhenikapl
Copy link
Contributor

Fixes: #340

@Yauhenikapl Yauhenikapl requested a review from atextor March 11, 2024 10:06
atextor
atextor requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@atextor atextor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far. It would be great to have an x-samm-aspect-modle-urn for the schemas as well (containing the URN of the Entity).

@Yauhenikapl Yauhenikapl requested a review from atextor March 11, 2024 13:18
@Yauhenikapl Yauhenikapl requested a review from atextor March 12, 2024 07:47
@Yauhenikapl Yauhenikapl merged commit b6ce399 into eclipse-esmf:main Mar 13, 2024
3 checks passed
@Yauhenikapl Yauhenikapl deleted the 340-add-model-information-to-the-openapi-spec branch March 13, 2024 05:59
@github-actions GitHub Actions
Copy link

Release v2.6.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atextor atextor atextor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add Model information to the Openapi Spec
2 participants
@Yauhenikapl @atextor