Create PUT/PATCH/POST methods for OpenApi #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - update OpenAPI generator; - add new flag for OpenAPI generation to commands; - update tests.
ysrbo
approved these changes
May 14, 2024
atextor
requested changes
May 21, 2024
There was a problem hiding this comment.
I think the following changes are necessary in this PR:
- PUT/POST/PATCH should be selectable separately. Sometimes it might make sense to have only a combination or subset of them.
- There should be corresponding test(s) for SammCli also, to check if the command line switch works as expected
- The test in the Maven Plugin should also have useful assertions, currently only the test case pom (generate-openapi-spec-json-pom-valid-aspect-model.xml) is adjusted, but not the test method(s)
Yauhenikapl
force-pushed
the
451-create-put-patch-post-in-openaPI-generatio
branch
from
748db9c to
96137fb
Compare
|
Release v2.8.0 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: