Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagram generation in multiple languages #706

Merged

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Feb 5, 2025

Description

Re-enable previous functionality of legacy diagram generation API to default to
generate diagrams in all languages if not set explicitly.

Fixes #705

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

In order to re-use the fluent assertions introduced in #703, the assertions are
moved from esmf-test-resources to the test-jar (test-shared sources) of
esmf-aspect-meta-model-java. This makes it consistent to use with the test-jar
provided by esmf-aspect-model-java-generator. Documentation was updated accordingly.

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 8beea4c into eclipse-esmf:main Feb 7, 2025
4 checks passed
@atextor atextor deleted the 705-diagram-generation-multiple-languages branch February 7, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants