Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keylisteners when using 'GLSPProjectionView' #191

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix keylisteners when using 'GLSPProjectionView' #191

merged 2 commits into from
Jul 27, 2022

Conversation

gabrieldulca
Copy link
Contributor

Fixes the Broken Keylisteners when using the GLSPProjection view by making the container div focusable.

@tortmayr tortmayr self-requested a review July 20, 2022 15:19
tortmayr
tortmayr requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems to work well for the Theia integration.
However, the styling of standalone example is broken:
Screenshot from 2022-07-20 17-19-18

Could you please have a look at that? Thanks!

@gabrieldulca gabrieldulca force-pushed the #689-projectionview-keylisteners branch from 7e423e4 to e516f80 Compare July 27, 2022 09:50
@gabrieldulca
Copy link
Contributor Author

Thanks for the feedback! The styling for the standalone example is now fixed.

@tortmayr tortmayr self-requested a review July 27, 2022 12:50
@tortmayr tortmayr merged commit 376c7c1 into eclipse-glsp:master Jul 27, 2022
@planger planger mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrieldulca @tortmayr