Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSP-77: Allow WebSocket connections to reconnect after interrupt #84

Merged
merged 1 commit into from
Jul 25, 2023
Merged

GLSP-77: Allow WebSocket connections to reconnect after interrupt #84

merged 1 commit into from
Jul 25, 2023

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Jul 20, 2023 •
edited
Loading

  • Update GLSP dependencies
  • Make use of GLSPWebSocketProvider in workflow example

Part of eclipse-glsp/glsp#77

Testing:

  • To simulate interrupts, you can use the corresponding testing branch issues/77-testing. This automatically interrupts the example twice with an timeout of 5s in between.

@ndoschek
GLSP-77: Allow WebSocket connections to reconnect after interrupt
417affd 
- Update GLSP dependencies
- Make use of GLSPWebSocketProvider in workflow example

Part of eclipse-glsp/glsp#77
@ndoschek ndoschek marked this pull request as ready for review July 24, 2023 09:29
@ndoschek ndoschek mentioned this pull request Jul 24, 2023
Closed
7 tasks
martin-fleck-at
martin-fleck-at approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the testing branch and everything seems to work as expected, thank you Nina!

@ndoschek ndoschek merged commit 0ae0e3c into master Jul 25, 2023
6 checks passed
@ndoschek ndoschek deleted the issues/77 branch July 25, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndoschek @martin-fleck-at