Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSP-1369: Update id locators in tests to align with workflow example #12

Merged
merged 5 commits into from
Jul 17, 2024
Merged

GLSP-1369: Update id locators in tests to align with workflow example #12

merged 5 commits into from
Jul 17, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Jul 15, 2024 •
edited
Loading

Part of eclipse-glsp/glsp#1369

What it does

  • Update id locators in tests
  • Switch to composite ts build
  • Update to latest dev config
  • Introduce generate:index helper script
  • Regenerate indices
  • Set version to 2.2.0 to align with other GLSP components
  • Update & cleanup package dependencies

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr
GLSP-1369: Update id locators in tests
469054f 
- Update id locators in tests
- Switch to composite ts build
- Update to latest dev config
- Introduce `generate:index` helper script
- Regenerate indices
- Set version to 2.2.0 to align with other GLSP components
- Update & cleanup package dependencies

Part of eclipse-glsp/glsp#1369
haydar-metin
haydar-metin approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@haydar-metin haydar-metin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, unfortunately, I don't have the rights to update the PR for this reason I have a small request (see comment).

Thanks for the changes!

examples/workflow-test/scripts/repositories.ts Outdated Show resolved Hide resolved
@tortmayr @haydar-metin
Update examples/workflow-test/scripts/repositories.ts
483a65b 
Co-authored-by: Haydar Metin <hmetin@eclipsesource.com>
@tortmayr tortmayr force-pushed the glsp-1369 branch 7 times, most recently from 0616dc2 to fbebf31 Compare July 17, 2024 07:22
@tortmayr
Add workflows for CI and publishing
9979fb8 
- Remove Jenkinsfile
- Update repo script to allow defining the protocol (ssh vs https)
@tortmayr
Copy link
Contributor Author

@haydar-metin
Thanks for the review. I have addressed your comments and also introduced GH action workflows to ensure that the playwright tests run on every RP and push to master

@tortmayr tortmayr merged commit 1e2e0bf into main Jul 17, 2024
4 checks passed
@tortmayr tortmayr deleted the glsp-1369 branch July 17, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydar-metin haydar-metin haydar-metin approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @haydar-metin