Websocket Keep-Alive

[glsp-bot]

Hi, after upgrading from 0.8.0-rc2 to 0.8.0 I ran into an issue with the new connection management.
In our application we have several tabs, similar to what the theia minimal example can do (but without theia).
In the application every diagram tab opens a seperate websocket connection to a single GLSP server instance.

Now, if there is no activity in a tab for 30 seconds the websocket times out and the GLSP server kills the ActionDispatcher which basically kills the server because no new ActionDispatcher is created for new connections.
Am I doing something wrong here? Shouldn't every connection create it's own Action Dispatcher?

Also I've seen that in the glsp-eclipse-integration project you have implemented a Keep-Alive Action and a GLSPServerManager that would probably prevent this case.
Are there plans to integrate this into the glsp-server project?

original thread by Daniel Benesch

[CamilleLetavernier]

Hi Daniel,

Now, if there is no activity in a tab for 30 seconds the websocket times out and the GLSP server kills the ActionDispatcher which basically kills the server because no new ActionDispatcher is created for new connections.

This looks like #149, which has been fixed right after 0.8.0 (So the fix is only available in 0.9.0 Nightlies at the moment).

I'm not sure about the Keep-Alive issue; but I guess it would make sense to have it available by default

[glsp-bot]

[Daniel Benesch]

The nightly looks better :) Thanks