Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling and simplify workflow example #492

Closed
planger opened this issue Jan 7, 2022 · 3 comments
Closed

Improve styling and simplify workflow example #492

planger opened this issue Jan 7, 2022 · 3 comments

Comments

@planger
Copy link
Member

planger commented Jan 7, 2022

No description provided.

@planger planger self-assigned this Jan 7, 2022
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 7, 2022
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Jan 7, 2022
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jan 7, 2022
eclipse-glsp/glsp#492

Change-Id: If205c7fca13acbc3b45a32894307ef0f2d6e523b
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jan 7, 2022
eclipse-glsp/glsp#492

Change-Id: If205c7fca13acbc3b45a32894307ef0f2d6e523b
planger added a commit to eclipse-glsp/glsp-server that referenced this issue Jan 17, 2022
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jan 17, 2022
planger added a commit to eclipse-glsp/glsp-client that referenced this issue Jan 17, 2022
planger added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Jan 24, 2022
  * Update GLSP dependency
  * Improve styling for VSCode
  * Change example file to the new format

eclipse-glsp/glsp#492
planger added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Jan 24, 2022
  * Update GLSP dependency
  * Improve styling for VSCode
  * Change example file to the new format

eclipse-glsp/glsp#492
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jan 27, 2022
The tool palette has somewhat ugly differently colored
pixels in the lower left and right corner as a
different background is inherited and shines
through because of the rounded corners.
With this change, we unset the background to get
rid of this effect.

eclipse-glsp/glsp#492

Change-Id: Ibe0c331c44d74f2369549fd2ab966e8135542154
planger added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jan 27, 2022
The tool palette has somewhat ugly differently colored
pixels in the lower left and right corner as a
different background is inherited and shines
through because of the rounded corners.
With this change, we unset the background to get
rid of this effect.

eclipse-glsp/glsp#492
planger added a commit to eclipse-glsp/glsp-vscode-integration that referenced this issue Feb 2, 2022
  * Update GLSP dependency
  * Improve styling for VSCode
  * Change example file to the new format
  * Update video

eclipse-glsp/glsp#492
@planger planger added this to the 1.0.0 Release milestone Feb 24, 2022
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Mar 14, 2022
- Switch from 0.9.0 release back to Snapshot/Next versions 
- Update to latest GLSP nightlies to consume the workflow styling improvements
- Update .wf files in the example workspace
- Update to typescript 4.5 (#559)
- Remove configs directory from client (no longer needed since we use the @eclipse-glsp/config package)

Part of eclipse-glsp/glsp/issues/492
Part of eclipse-glsp/glsp/issues/559
tortmayr added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Mar 15, 2022
- Switch from 0.9.0 release back to Snapshot/Next versions 
- Update to latest GLSP nightlies to consume the workflow styling improvements
- Update .wf files in the example workspace
- Update to typescript 4.5 (#559)
- Remove configs directory from client (no longer needed since we use the @eclipse-glsp/config package)

Part of eclipse-glsp/glsp/issues/492
Part of eclipse-glsp/glsp/issues/559
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Mar 28, 2022
#472
- Consume the new glsp-protocol version and update the code base to comply to the new action definitions

 #559
- Consume new @eclipse-glsp/config version and update to typescript 4.5.5.
- Adapt code to conform to new "strict" mode and "noImplicitOverride"
- Cleanup dev dependencies and move common dependencies into package root

#492
Update workflow builders to provide the same improved styled components as the Java GLSP server


Part of eclipse-glsp/glsp/issues/472
Part of eclipse-glsp/glsp/issues/559
Part of eclipse-glsp/glsp/issues/492

Requires eclipse-glsp/glsp-client#171

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Mar 30, 2022
#472
- Consume the new glsp-protocol version and update the code base to comply to the new action definitions

 #559
- Consume new @eclipse-glsp/config version and update to typescript 4.5.5.
- Adapt code to conform to new "strict" mode and "noImplicitOverride"
- Cleanup dev dependencies and move common dependencies into package root

#492
Update workflow builders to provide the same improved styled components as the Java GLSP server


Part of eclipse-glsp/glsp/issues/472
Part of eclipse-glsp/glsp/issues/559
Part of eclipse-glsp/glsp/issues/492

Requires eclipse-glsp/glsp-client#171

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Mar 30, 2022
#472
- Consume the new glsp-protocol version and update the code base to comply to the new action definitions

 #559
- Consume new @eclipse-glsp/config version and update to typescript 4.5.5.
- Adapt code to conform to new "strict" mode and "noImplicitOverride"
- Cleanup dev dependencies and move common dependencies into package root

#492
Update workflow builders to provide the same improved styled components as the Java GLSP server


Part of eclipse-glsp/glsp/issues/472
Part of eclipse-glsp/glsp/issues/559
Part of eclipse-glsp/glsp/issues/492

Requires eclipse-glsp/glsp-client#171

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Mar 30, 2022
#472
- Consume the new glsp-protocol version and update the code base to comply to the new action definitions

 #559
- Consume new @eclipse-glsp/config version and update to typescript 4.5.5.
- Adapt code to conform to new "strict" mode and "noImplicitOverride"
- Cleanup dev dependencies and move common dependencies into package root

#492
Update workflow builders to provide the same improved styled components as the Java GLSP server


Part of eclipse-glsp/glsp/issues/472
Part of eclipse-glsp/glsp/issues/559
Part of eclipse-glsp/glsp/issues/492

Requires eclipse-glsp/glsp-client#171

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this issue Mar 30, 2022
#472
- Consume the new glsp-protocol version and update the code base to comply to the new action definitions

 #559
- Consume new @eclipse-glsp/config version and update to typescript 4.5.5.
- Adapt code to conform to new "strict" mode and "noImplicitOverride"
- Cleanup dev dependencies and move common dependencies into package root

#492
Update workflow builders to provide the same improved styled components as the Java GLSP server


Part of eclipse-glsp/glsp/issues/472
Part of eclipse-glsp/glsp/issues/559
Part of eclipse-glsp/glsp/issues/492

Requires eclipse-glsp/glsp-client#171

Contributed on behalf of STMicroelectronics
@planger
Copy link
Member Author

planger commented Apr 4, 2022

@tortmayr Thanks for also addressing the Eclipse integration. I think this is now done, is it? If not please feel free to reopen.

@planger planger closed this as completed Apr 4, 2022
@tortmayr
Copy link
Contributor

tortmayr commented Apr 4, 2022

I think we are, however, I'm not sure whether we also have updated all gifs/mpegs 😉

@planger
Copy link
Member Author

planger commented Apr 4, 2022

Right, good catch!
I can take care of the Eclipse integration (I have it open currently anyway).
Can you please take care of the standalone?

planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Apr 4, 2022
planger added a commit to eclipse-glsp/glsp-eclipse-integration that referenced this issue Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants