Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser-app not built with latest master #952

Closed
tortmayr opened this issue Mar 9, 2023 · 1 comment · Fixed by eclipse-glsp/glsp-theia-integration#148
Closed

Browser-app not built with latest master #952

tortmayr opened this issue Mar 9, 2023 · 1 comment · Fixed by eclipse-glsp/glsp-theia-integration#148
Labels
bug Something isn't working theia

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Mar 9, 2023

Apparently this is caused by an underlying upgrade of nx to version 15.8.5. Since this version projects in the workspace that are named "browser-app" seem to be ignored and are no part of the command streaming for building/linting.
Unfortunatley lerna has a fluent dependency on nx so it's not easily possible to simply pin the nx version used.
Instead I recommend to rename the browser-app folder to something like workflow-browser-app. This seems to fix the problem.
Apparently only the exact name "browser-app" is blacklisted, everything else works. We should try to avoid this naming scheme in the future.

@tortmayr
Copy link
Contributor Author

As it turns out newer nx versions also parse the ".gitignore" file. You have to make sure that the root folder of your workspace packages is not excluded via gitignore

@tortmayr tortmayr changed the title Browser-app not build with latest master Browser-app not built with latest master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theia
Projects
None yet
1 participant