Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that browser-app is no excluded from workspaces build #148

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

tortmayr
Copy link
Contributor

Newer lerna/nx versions don't build projects whose root folder is gitignored
=> update .gitignore to ensure that the browser-app is properly included into the lerna workspaces
Fixes eclipse-glsp/glsp#952

Newer lerna/nx versions don't build projects whose root folder is gitignored
=> update .gitignore to ensure that the browser-app is properly included into the lerna workspaces
Fixes https://github.com/eclipse-glsp/glsp/issues/952A
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 00910e5 into master Mar 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser-app not built with latest master
2 participants