Fix hara client stopping crash #54 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the crash when haraClient is stopped during the Downloading/Updating state due to actors were not closed properly. (Reported in #54) Added unit tests for the applied fix UF-930 Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
This commit updates the docker compose command from `docker-compose` to `docker compose`. The command `docker-compose` is deprecated in v2 and `docker compose` is the new command to manage docker containers. https://docs.docker.com/compose/migrate/ Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
SaeedRe
force-pushed
the
fix-hara-client-stopping-crash-#54
branch
from
05a47fd
to
de34262
Compare
andrea-zoleo
approved these changes
Aug 6, 2024
diegorondini
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the crash when haraClient is stopped during the Downloading/Updating state.
The crash occurred because all created actors were not closed properly.
Reported in #54
Also added unit tests related to the applied fix to ensure it's consistency.