Trigger next rollout group - backend and management API implementatio… #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns. Backend and management API tests. Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
|
Can one of the admins verify this patch? |
|
Please make sure to test also edge and error cases on management level (not existing rollout, different combinations of rollouts states and group states, ...) |
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
StefanKlt
suggested changes
Nov 24, 2022
...y/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/RolloutManagement.java
Show resolved
Hide resolved
...y/hawkbit-repository-api/src/main/java/org/eclipse/hawkbit/repository/RolloutManagement.java
Outdated
Show resolved
Hide resolved
...it-repository-jpa/src/main/java/org/eclipse/hawkbit/repository/jpa/JpaRolloutManagement.java
Outdated
Show resolved
Hide resolved
...t-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/RolloutManagementTest.java
Outdated
Show resolved
Hide resolved
...t-repository-jpa/src/test/java/org/eclipse/hawkbit/repository/jpa/RolloutManagementTest.java
Show resolved
Hide resolved
...t-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtRolloutResourceTest.java
Outdated
Show resolved
Hide resolved
...t-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtRolloutResourceTest.java
Outdated
Show resolved
Hide resolved
...t-resource/src/test/java/org/eclipse/hawkbit/mgmt/rest/resource/MgmtRolloutResourceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
…rollout group in rollout view. Signed-off-by: Dimitar Shterev <dimitar.shterev@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
… all rollout states.
…up_ui Trigger next rollout group - UI changes. New button for trigger next rollout group.
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
Signed-off-by: Stefan Klotz <stefan.klotz@bosch.io>
| @@ -1033,14 +1040,95 @@ private void postRollout(final String name, final int groupSize, final Long dist | |||
|
|
|||
| private Rollout createRollout(final String name, final int amountGroups, final long distributionSetId, | |||
| final String targetFilterQuery) { | |||
| final Rollout rollout = rolloutManagement.create( | |||
| final Rollout rollout = createRolloutInCreatingSatate(name, amountGroups, distributionSetId, targetFilterQuery); | |||
There was a problem hiding this comment.
Suggested change
| final Rollout rollout = createRolloutInCreatingSatate(name, amountGroups, distributionSetId, targetFilterQuery); | |
| final Rollout rollout = createRolloutInCreatingState(name, amountGroups, distributionSetId, targetFilterQuery); |
StefanKlt
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger next rollout group - Back-end and management API implementation. Back-end and management API tests.
Signed-off-by: Dimitar Shterev dimitar.shterev@bosch.io