Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#932] Fix compile error with Java 8 for S2I #934

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Nov 30, 2018

No description provided.

@ctron ctron self-assigned this Nov 30, 2018
@ctron ctron requested a review from dejanb November 30, 2018 13:01
@ctron ctron changed the title [932#] Fix compile error with Java 8 for S2I [#932] Fix compile error with Java 8 for S2I Nov 30, 2018
@codecov
Copy link

codecov bot commented Nov 30, 2018

Codecov Report

Merging #934 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #934      +/-   ##
============================================
- Coverage     69.99%   69.64%   -0.36%     
  Complexity      393      393              
============================================
  Files           230      230              
  Lines         11133    11133              
  Branches        986      986              
============================================
- Hits           7793     7754      -39     
- Misses         2582     2621      +39     
  Partials        758      758
Impacted Files Coverage Δ Complexity Δ
...e/hono/service/auth/BaseAuthenticationService.java 61.9% <0%> (-28.58%) 0% <0%> (ø)
...va/org/eclipse/hono/service/HealthCheckServer.java 83.33% <0%> (-9.53%) 0% <0%> (ø)
...org/eclipse/hono/service/amqp/AmqpServiceBase.java 71.59% <0%> (-5.06%) 0% <0%> (ø)
.../org/eclipse/hono/service/AbstractApplication.java 50.98% <0%> (-4.91%) 0% <0%> (ø)
...se/hono/connection/impl/ConnectionFactoryImpl.java 77.14% <0%> (-2.86%) 0% <0%> (ø)
...er/mqtt/AbstractVertxBasedMqttProtocolAdapter.java 74.61% <0%> (-1.34%) 0% <0%> (ø)
...a/org/eclipse/hono/client/impl/HonoClientImpl.java 77.51% <0%> (-0.26%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595eadc...f79e3d7. Read the comment docs.

@@ -407,7 +407,7 @@ objects:
name: fabric8-s2i-java-custom:2.3
env:
- name: MAVEN_ARGS_APPEND
value: -B -pl org.eclipse.hono:hono-adapter-amqp-vertx --also-make -Pnetty-tcnative
value: -B -pl org.eclipse.hono:hono-adapter-amqp-vertx --also-make -Pnetty-tcnative -Dmaven.test.skip=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, is that really what you want to do, i.e. not run the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I need to do, in order to work around this issue.

On the other side, this is a released version of Hono. So I am not sure if re-running the unit tests, for every local installation, is necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Just wanted be sure we know what we're doing ;-)

@ctron ctron mentioned this pull request Dec 3, 2018
@ctron ctron merged commit b5f11c0 into eclipse-hono:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants