-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting RPATH for iceoryx artifacts #1287
Comments
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…e tasks Signed-off-by: Christian Eltzschig <me@elchris.org>
… and add missing LICENSE file to hoofs platform Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…-tidy check is performed via tools/scripts/clang_tidy_check.sh Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…NIQUE_INCLUDEDIR Signed-off-by: Christian Eltzschig <me@elchris.org>
…wrappers Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…xecutable Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ld process compatible with our iceoryx_meta and colcon, and also correctly set for relocatable install Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
… binding_c Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…ws sdk: microsoft/vcpkg#15035 (comment) Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…xecutable_path required for apps Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
… example to new cmake api Signed-off-by: Christian Eltzschig <me@elchris.org>
…ld script Signed-off-by: Christian Eltzschig <me@elchris.org>
… fix Windows SDK compilation failure Signed-off-by: Christian Eltzschig <me@elchris.org>
…ed dependencies Signed-off-by: Christian Eltzschig <me@elchris.org>
Signed-off-by: Christian Eltzschig <me@elchris.org>
…nted Signed-off-by: Christian Eltzschig <me@elchris.org>
…nted Signed-off-by: Christian Eltzschig <me@elchris.org>
…nted Signed-off-by: Christian Eltzschig <me@elchris.org>
…nted Signed-off-by: Christian Eltzschig <me@elchris.org>
…iceoryx-targets iox-#1287 setting rpath for all iceoryx targets
@elfenpiff is this really finished? There are some open tasks |
@elfenpiff It seems the PR for this issue broke the installation of the header. The Additionally the tests are also installed. This is different from before the changes. Not sure if they should also be installed. |
Reopening due to the duplicate installation of |
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…y and not directly Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…package Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
iox-#1287 Fix CMake install paths
Signed-off-by: Christian Eltzschig <me@elchris.org>
Brief feature description
Setting the RPATH in cmake makes it easier to use iceoryx build as dynamic lib since the path to the lib will be stored in RouDi and the examples.
Detailed information
Building iceoryx as dynamic lib and using it is cumbersome since one has to add the installation path to the
LD_LIBRARY_PATH
/DYLD_LIBRARY_PATH
. Setting the RPATH removes this additional step by embedding the path to the libraries inside the binaries.Additional information:
Instead of setting the absolute path with
${CMAKE_INSTALL_PREFIX}/lib
we should consider using relative paths like$ORIGIN/../${CMAKE_INSTALL_LIBDIR}
or@loader_path/../${CMAKE_INSTALL_LIBDIR}
on macOS. This has the advantage that the install directory can be copied and the binaries still find the correct librariesTodo
CMakeLists.txt
so that they use the iceoryx wrappersiox_add_library
oriox_add_executable
RPATH
in the iceoryx wrappers correctly-Wno-pedantic -Wno-conversion
)iceoryx_posh
is build inbuild/posh
.APPLE
platform iniox_add_executable
.RPATH
auto detection to solve posh dependencies in hoofs. See comment: iox-#1287 setting rpath for all iceoryx targets #1357 (comment)The text was updated successfully, but these errors were encountered: