Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide API docu for private/internal constructs on website #745

Closed
elfenpiff opened this issue Apr 16, 2021 · 5 comments · Fixed by #941
Closed

Hide API docu for private/internal constructs on website #745

elfenpiff opened this issue Apr 16, 2021 · 5 comments · Fixed by #941
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

At the moment the website shows the full API documentation of constructs which are filed under the directory "internal", are private/protected nested classes or methods.

The website should only contain the public user API documentation.

Detailed information

Adjust the doxygen configuration files so that it is not generated when:

  • the class is a protected/private nested class of some class
  • the class/function/variable is in the namespace internal
  • the methods/variables are protected or private
  • the class is stored under the directory internal
@elfenpiff elfenpiff added this to the Prio 1 milestone Apr 16, 2021
@mossmaurice
Copy link
Contributor

@budrus @dkroenke and myself concluded that we don't need to differentiate between public and private API. Most people will use the search functionality on iceoryx.io anyway. Hence, closing this issue.

@elBoberido
Copy link
Member

@mossmaurice I strongly suggest to rethink this. The search functionality also lists the private header which makes it hard for users to easily grasp what they can use. Furthermore, try to search for the publisher API. It's a mess.

Oh, and I just noticed that doxygen creates the wrong include paths. Look here https://iceoryx.io/v1.0.1/API-reference/posh/Classes/structiox_1_1popo_1_1PublisherOptions/. It's #include <publisher_options.hpp> but should be include <iceoryx_posh/popo/publisher_options.hpp>. Do you know if this can be fixed? if not it might be better to nod have it there.

@elfenpiff
Copy link
Contributor Author

@elBoberido I completely agree! And sadly somehow I did not realize that this issue was closed therefore I intervene now and reopen the issue.

@elfenpiff elfenpiff reopened this Sep 7, 2021
@mossmaurice
Copy link
Contributor

mossmaurice commented Sep 7, 2021

Still 3:2 for closing this issue 😛 Just kidding, I added it to the agenda of next weeks dev meetup.

Do you know if this can be fixed?

Not atm, please track this point somewhere, else it'll be forgotten. Maybe @ithier can help?

@elBoberido
Copy link
Member

@mossmaurice I think this is more of a doxygen issue instead of mkdocs issue. I will create an issue for this

Regarding the other topic. @MatthiasKillat once proposed to slightly adjust the folder structure. I don't fully recall his proposal but it made sense when he did it. It think it was something similar to this

|- include
  |- iceoryx_hoofs
    |- cxx
    |- ...
|- src
  |- include
    |- iceoryx_hoofs
      |- internal
        |- cxx
        |- ... 

With this, the include paths would remain the same and we can also install the internal headers to the same location but it's now easy to have only the public header in doxygen.

@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Sep 16, 2021
@elfenpiff elfenpiff removed their assignment Sep 16, 2021
dkroenke added a commit to ApexAI/iceoryx that referenced this issue Oct 14, 2021
…ation

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
@dkroenke dkroenke self-assigned this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants