Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix wrapper should be silent on success #971

Closed
elfenpiff opened this issue Nov 12, 2021 · 0 comments · Fixed by #1317
Closed

posix wrapper should be silent on success #971

elfenpiff opened this issue Nov 12, 2021 · 0 comments · Fixed by #1317
Assignees
@elfenpiff

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

The posix wrapper for the shared memory prints a lot of debug information when it was created successfully. On success a posix wrapper should always be silent so that the user can decide what to print and what not - if the wrapper does it for the user it is hard to turn it of.

Remove all the outputs from the shared memory object which are printed on success and move them in the implementation which is using the shared memory object.
@elfenpiff elfenpiff self-assigned this Apr 5, 2022
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Remove success output in shared memory object
98342f0 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Add release note
0cdd3eb 
Signed-off-by: Christian Eltzschig <me@elchris.org>
@elfenpiff elfenpiff mentioned this issue Apr 5, 2022
Merged
21 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Remove success output in shared memory object
de16213 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Add release note
837578d 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Introduce hoofs_logging and use LogDebug/LogE…
1b5eb50 
…rror instead cout/clog/cerr in shared memory object

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 5, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Adjust log strategy for hoofs
1d5e2e6 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit that referenced this issue Apr 6, 2022
@elfenpiff
Merge pull request #1317 from ApexAI/iox-#971-shared-memory-abstracti…
6dd7123 
…on-silent-on-success

iox-#971 Remove success output in shared memory object
@elfenpiff elfenpiff mentioned this issue Apr 6, 2022
Open
29 tasks
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 6, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Remove success output in shared memory object
d98bcf7 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 6, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Add release note
df81573 
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 6, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Introduce hoofs_logging and use LogDebug/LogE…
e80cc74 
…rror instead cout/clog/cerr in shared memory object

Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff added a commit to ApexAI/iceoryx that referenced this issue Apr 6, 2022
@elfenpiff
iox-eclipse-iceoryx#971 Adjust log strategy for hoofs
f351f10 
Signed-off-by: Christian Eltzschig <me@elchris.org>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
@elfenpiff @andre-nguyen
iox-eclipse-iceoryx#971 Remove success output in shared memory object
3c7743d 
Signed-off-by: Christian Eltzschig <me@elchris.org>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
@elfenpiff @andre-nguyen
iox-eclipse-iceoryx#971 Add release note
6a3ac7d 
Signed-off-by: Christian Eltzschig <me@elchris.org>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
@elfenpiff @andre-nguyen
iox-eclipse-iceoryx#971 Introduce hoofs_logging and use LogDebug/LogE…
0f0e054 
…rror instead cout/clog/cerr in shared memory object

Signed-off-by: Christian Eltzschig <me@elchris.org>
andre-nguyen pushed a commit to andre-nguyen/iceoryx that referenced this issue Apr 22, 2022
@elfenpiff @andre-nguyen
iox-eclipse-iceoryx#971 Adjust log strategy for hoofs
e3207ef 
Signed-off-by: Christian Eltzschig <me@elchris.org>
@mossmaurice mossmaurice mentioned this issue Jan 28, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iox-#971 Remove success output in shared memory object ApexAI/iceoryx
1 participant
@elfenpiff