Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IpcCapable trait #162

Closed
elfenpiff opened this issue Mar 21, 2024 · 0 comments · Fixed by #163
Closed

Refactor IpcCapable trait #162

elfenpiff opened this issue Mar 21, 2024 · 0 comments · Fixed by #163
Assignees
@elfenpiff

Comments

@elfenpiff
Copy link
Contributor

Brief feature description

Currently, the iceoryx2_bb_posix::IpcCapable trait has too much responsibility for the layer it is located on. It shall not perform reference counting to ensure lifetime - what if the process crashes and the ref-count is unusable.
Furthermore, some resources shall persist even when no process is actively using them.

The solution is an HandleStorage that holds the handle, the handle itself destroys the resource in drop and the storage tracks if it is IpcCapable or not.
@elfenpiff elfenpiff self-assigned this Mar 21, 2024
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Introduce ipc_capable trait
2bf697d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Refactor ipc_capable and integrate this into ba…
11e8cec 
…rrier
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into semaphore
2bcc521
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Add ipc capable trait tests
f38d264
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into mutex
2237fc4
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Introduce ipc_capable trait
ac5ec3d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Refactor ipc_capable and integrate this into ba…
a47960d 
…rrier
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into semaphore
ea42d2a
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Add ipc capable trait tests
3ce9b65
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into mutex
5910244
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into read-write-mutex
42fd1ad
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Remove unmovable ipc handle
7775752
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Update release notes
b2fc8f6
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 21, 2024
@elfenpiff
[eclipse-iceoryx#162] Fix clippy warnings
fbf060c
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 22, 2024
@elfenpiff
[eclipse-iceoryx#162] Fix clippy warnings
5ba30c5
@elfenpiff elfenpiff mentioned this issue Mar 22, 2024
Merged
17 tasks
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 22, 2024
@elfenpiff
[eclipse-iceoryx#162] Fix clippy warnings
987844c
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 22, 2024
@elfenpiff
[eclipse-iceoryx#162] Fix clippy warnings
743a798
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] More detailed docu; remove HandleState; rename …
f4be299 
…state -> is_initialized
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Introduce ipc_capable trait
285cdf9
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Refactor ipc_capable and integrate this into ba…
dbf5835 
…rrier
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into semaphore
0342893
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Add ipc capable trait tests
6d0d9b8
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into mutex
776868e
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Integrate IpcCapable trait into read-write-mutex
ca983bf
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Remove unmovable ipc handle
20d2e36
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Update release notes
66fe37d
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] Fix clippy warnings
a6610f9
elfenpiff added a commit to elfenpiff/iceoryx2 that referenced this issue Mar 26, 2024
@elfenpiff
[eclipse-iceoryx#162] More detailed docu; remove HandleState; rename …
dcd8c43 
…state -> is_initialized
elfenpiff added a commit that referenced this issue Mar 26, 2024
@elfenpiff
Merge pull request #163 from elfenpiff/iox2-162-refactor-ipc-capable-…
5efe147 
…trait

[#162] refactor ipc capable trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elfenpiff elfenpiff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#162] refactor ipc capable trait elfenpiff/iceoryx2
1 participant
@elfenpiff