Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename char in platform to c_char #54

Closed
elfenpiff opened this issue Dec 21, 2023 · 0 comments · Fixed by #68
Closed

Rename char in platform to c_char #54

elfenpiff opened this issue Dec 21, 2023 · 0 comments · Fixed by #68
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@elfenpiff
Copy link
Contributor

(Code) Example Of Cumbersome API

The type alias char in iceoryx2_pal/posix/src/$PLATFORM$/types.rs is mapped to core::ffi::c_char and not u8, this may lead to mixing it up with the rust primitive type char.

Improvement Suggestion

To have a clear distinction, the type alias in types.rs shall be renamed to c_char
@elfenpiff elfenpiff added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2023
@elfenpiff elfenpiff mentioned this issue Dec 21, 2023
Merged
17 tasks
Shock-1 added a commit to Shock-1/iceoryx2 that referenced this issue Jan 2, 2024
@Shock-1
[eclipse-iceoryx#54] Rename char in types.rs to c_char.
fc7dc90 
- Changes propogated
@Shock-1 Shock-1 mentioned this issue Jan 2, 2024
Merged
17 tasks
Shock-1 added a commit to Shock-1/iceoryx2 that referenced this issue Jan 2, 2024
@Shock-1
[eclipse-iceoryx#54] Fix formatting
0b9f0f6
Shock-1 added a commit to Shock-1/iceoryx2 that referenced this issue Jan 2, 2024
@Shock-1
[eclipse-iceoryx#54] Propogate changes to remaining platforms.
6567262
Shock-1 added a commit to Shock-1/iceoryx2 that referenced this issue Jan 5, 2024
@Shock-1
[eclipse-iceoryx#54] Fix for Windows. Fix remaining char instead of c…
e752ce2 
…_char.
Shock-1 added a commit to Shock-1/iceoryx2 that referenced this issue Jan 5, 2024
@Shock-1
[eclipse-iceoryx#54] Fix formatting.
0fb8390
elfenpiff added a commit that referenced this issue Jan 6, 2024
@elfenpiff
Merge pull request #68 from Shock-1/iox2-54
33ab53b 
[#54] Rename char in types.rs to c_char.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#54] Rename char in types.rs to c_char. Shock-1/iceoryx2
1 participant
@elfenpiff