Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kebab case for config file #90

Closed
elfenpiff opened this issue Jan 16, 2024 · 0 comments · Fixed by #250
Closed

Kebab case for config file #90

elfenpiff opened this issue Jan 16, 2024 · 0 comments · Fixed by #250
Assignees
@elBoberido
Labels
enhancement New feature or request

Comments

@elfenpiff
Copy link
Contributor

(Code) Example Of Cumbersome API

To cite @elBoberido

Btw, for config files it is nicer to have kebab-case for the variable names. You just need to use #[serde(rename_all = "kebab-case")]. Just in case you want to change it in a future version. We are still quite new with iceoryx2 so we still have the chance without breaking too much. I could take care of that if you like the idea.

I like it, so have fun @elBoberido
@elfenpiff elfenpiff added the enhancement New feature or request label Jan 16, 2024
@elfenpiff elfenpiff changed the title Kebap case for config file Kebab case for config file Jan 16, 2024
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Kebab case for config file
f14efa1
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Set log level to 'Info' for benchmarks
ce481ad
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Update changelog
efd1009
@elBoberido elBoberido mentioned this issue Jun 20, 2024
Merged
17 tasks
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Kebab case for config file
651ed52
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Set log level to 'Info' for benchmarks
ae1a3ae
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Update changelog
3fa9300
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Kebab case for config file
e5b0344
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Set log level to 'Info' for benchmarks
b5df9d0
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Update changelog
34e9603
elBoberido added a commit to elBoberido/iceoryx2 that referenced this issue Jun 20, 2024
@elBoberido
[eclipse-iceoryx#90] Add badge for CI status
9aee216
elBoberido added a commit that referenced this issue Jun 21, 2024
@elBoberido
Merge pull request #250 from elBoberido/iox2-90-kebab-case-for-config…
ad6dcd0 
…-files

[#90] Kebab-case for config files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elBoberido elBoberido

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#90] Kebab-case for config files elBoberido/iceoryx2
2 participants
@elfenpiff @elBoberido