Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#360] benchmark improvements #362

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Aug 30, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #360

@elfenpiff elfenpiff requested a review from elBoberido August 30, 2024 15:47
@elfenpiff elfenpiff self-assigned this Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (50b6387) to head (02fe98d).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   80.15%   80.12%   -0.03%     
==========================================
  Files         193      193              
  Lines       22702    22702              
==========================================
- Hits        18197    18191       -6     
- Misses       4505     4511       +6     

see 6 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 6089d60 into eclipse-iceoryx:main Aug 30, 2024
53 of 55 checks passed
@elfenpiff elfenpiff deleted the iox2-360-benchmark-improvements branch August 30, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark Release Preparations
2 participants