[Enhanced Switch] ECG generated code hangs (#3398)

* Fixes #3395
eclipse-jdt · Dec 4, 2024 · 1e3e3a9 · 1e3e3a9
1 parent 0c7adc8
commit 1e3e3a9
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 2 deletions.
diff --git a/...ipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/CaseStatement.java b/...ipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/CaseStatement.java
@@ -358,8 +358,8 @@ public void generateCode(BlockScope currentScope, CodeStream codeStream) {
 		}
 		patternMatchLabel.place();
 	} else {
-		if (this.swich.containsNull)
-			this.swich.nullProcessed |= true;
+		if (this.swich.nullCase == this)
+			this.swich.nullProcessed = true;
 	}
 	codeStream.recordPositionsFrom(pc, this.sourceStart);
 }

diff --git a/....tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/SwitchPatternTest.java b/....tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/SwitchPatternTest.java
@@ -9587,4 +9587,45 @@ public interface X {
 				"B1 -> B1, B1\n" +
 				"B2 -> B2, B2");
 	}
+
+	// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/3395
+	// [Enhanced Switch] ECG generated code hangs
+	public void testIssue3395() {
+		runConformTest(
+				new String[] {
+						"X.java",
+						"""
+						public class X {
+							public static void main(String[] args) {
+	                            for (String s : new String [] { "World", "Check", "Hello", "Null", "Default" }) {
+                                    String sel = s.equals("Null") ? null : s;
+									switch (sel) {
+										case "World" -> System.out.print("World");
+										case String str when s.equals("Check") -> System.out.print("Check");
+										case "Hello" -> System.out.print("Hello");
+										case null -> System.out.print("Null");
+										default -> System.out.print("Default");
+									}
+									System.out.print("--");
+								}
+								System.out.println("");
+                                for (String s : new String [] { "Default", "Null", "Hello", "Check", "World" }) {
+                                    String sel = s.equals("Null") ? null : s;
+									switch (sel) {
+										case "World" -> System.out.print("World");
+										case String str when s.equals("Check") -> System.out.print("Check");
+										case "Hello" -> System.out.print("Hello");
+										case null -> System.out.print("Null");
+										default -> System.out.print("Default");
+									}
+									System.out.print("--");
+								}
+								System.out.println("");
+							}
+						}
+						""",
+				},
+				"World--Check--Hello--Null--Default--\n" +
+				"Default--Null--Hello--Check--World--");
+	}
 }