Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21][dom] APIs deprecation and cleanup #1340

Closed
Tracked by #891
mpalat opened this issue Sep 2, 2023 · 5 comments
Closed
Tracked by #891

[21][dom] APIs deprecation and cleanup #1340

mpalat opened this issue Sep 2, 2023 · 5 comments
Assignees
@jarthana
Milestone
BETA_JAVA21

Comments

@mpalat
Copy link
Contributor

mpalat commented Sep 2, 2023

20 -> 21
cleanups
@mpalat mpalat added this to the BETA_JAVA21 milestone Sep 2, 2023
@mpalat mpalat mentioned this issue Sep 1, 2023
Closed
7 tasks
@mpalat
Copy link
Contributor Author

mpalat commented Sep 2, 2023

@jarthana - in case this is not covered in move to 21, created this issue

@jarthana
Copy link
Member

jarthana commented Sep 4, 2023

I covered quite a few of these during #1316. But didn't bother with API upgrades/deprecation and such. Let me do a check later and see what it takes.

@jarthana
Copy link
Member

jarthana commented Sep 4, 2023

OK, some of the tests were disabled, so I missed out on an important detail. In Java 21, record patterns don't have pattern variable names. I am planning to remove this new DOM property from RecordPattern and adjust tests accordingly.

@noopur2507 I will post a patch shortly. Please go through the API changes and let me know if you have any comments.

jarthana added a commit to jarthana/eclipse.jdt.core that referenced this issue Sep 4, 2023
@jarthana
[21][dom] APIs deprecation and cleanup eclipse-jdt#1340
a6654b6
@jarthana jarthana mentioned this issue Sep 4, 2023
Merged
3 tasks
noopur2507 added a commit to eclipse-jdt/eclipse.jdt.ui that referenced this issue Sep 4, 2023
@noopur2507
[21][dom] APIs deprecation and cleanup #1340
b0d391f 
Update UI code

eclipse-jdt/eclipse.jdt.core#1340
@noopur2507 noopur2507 mentioned this issue Sep 4, 2023
Merged
3 tasks
@noopur2507
Copy link
Member

@jarthana Please release the attached UI patch after the Core patch.

jarthana added a commit to jarthana/eclipse.jdt.core that referenced this issue Sep 5, 2023
@jarthana
[21][dom] APIs deprecation and cleanup eclipse-jdt#1340
cc45c4b
jarthana pushed a commit to eclipse-jdt/eclipse.jdt.ui that referenced this issue Sep 5, 2023
@noopur2507
[21][dom] APIs deprecation and cleanup #1340 (#748)
21027e2 
Update UI code

eclipse-jdt/eclipse.jdt.core#1340
@jarthana
Copy link
Member

jarthana commented Sep 5, 2023

Both core and corresponding UI changes have been merged now.

@jarthana jarthana closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarthana jarthana

Labels
None yet
Projects
None yet
Milestone
BETA_JAVA21
Development

No branches or pull requests
3 participants
@jarthana @mpalat @noopur2507