Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch][Pattern] Withdraw the internal AST APIs Pattern.suspendVariables & Pattern.resumeVariables #2019

Closed
srikanth-sankaran opened this issue Feb 14, 2024 · 0 comments · Fixed by #2011
Closed

[Switch][Pattern] Withdraw the internal AST APIs Pattern.suspendVariables & Pattern.resumeVariables #2019

srikanth-sankaran opened this issue Feb 14, 2024 · 0 comments · Fixed by #2011
Assignees
@srikanth-sankaran
Milestone
MilestoneNxt

Comments

@srikanth-sankaran
Copy link
Contributor

These seem to have been introduced to handle type switch code generation - to manage live variables in regions of "trampoline" code that don't correspond to source code but are needed to invoke the bootstrap correctly.

This is a heavy weight way of managing things.

The simpler, more direct way is to simply call
org.eclipse.jdt.internal.compiler.lookup.LocalVariableBinding.recordInitializationEndPC and
org.eclipse.jdt.internal.compiler.lookup.LocalVariableBinding.recordInitializationStartPC(int)
@srikanth-sankaran srikanth-sankaran self-assigned this Feb 14, 2024
@srikanth-sankaran srikanth-sankaran added this to the 4.32 M1 milestone Feb 14, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 14, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
0c76843 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
@srikanth-sankaran srikanth-sankaran mentioned this issue Feb 14, 2024
Merged
3 tasks
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 15, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
1b7f711 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 16, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
b257d3a 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 18, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
7b0ef8e 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
@mpalat mpalat modified the milestones: 4.32 M1, MilestoneNxt Mar 1, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Mar 5, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
4532924 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@srikanth-sankaran
* Withdraw the internal AST APIs Pattern.suspendVariables &
466d256 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@srikanth-sankaran @gayanper
* Withdraw the internal AST APIs Pattern.suspendVariables &
bc334ca 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
snjeza pushed a commit to snjeza/eclipse.jdt.core that referenced this issue Oct 21, 2024
@srikanth-sankaran @snjeza
* Withdraw the internal AST APIs Pattern.suspendVariables &
4207b9d 
Pattern.resumeVariables

* Fixes eclipse-jdt#2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-sankaran srikanth-sankaran

Labels
None yet
Projects
None yet
Milestone
MilestoneNxt
Development

Successfully merging a pull request may close this issue.

[Patterns] Cumulative fixes for various problems srikanth-sankaran/eclipse.jdt.core
2 participants
@mpalat @srikanth-sankaran