Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns][internal] High degree of code duplication in instanceof pattern code generation #2021

Closed
srikanth-sankaran opened this issue Feb 14, 2024 · 0 comments · Fixed by #2011
Closed

[Patterns][internal] High degree of code duplication in instanceof pattern code generation #2021

srikanth-sankaran opened this issue Feb 14, 2024 · 0 comments · Fixed by #2011
Assignees
@srikanth-sankaran
Milestone
MilestoneNxt

Comments

@srikanth-sankaran
Copy link
Contributor

The two methods org.eclipse.jdt.internal.compiler.ast.InstanceOfExpression.generateCode(BlockScope, CodeStream, boolean) and org.eclipse.jdt.internal.compiler.ast.InstanceOfExpression.generateOptimizedBoolean(BlockScope, CodeStream, BranchLabel, BranchLabel, boolean) duplicate a lot of code. It should be investigated whether one of them can simply call the other one or if the common code could be factored into a subroutine
@srikanth-sankaran srikanth-sankaran self-assigned this Feb 14, 2024
@srikanth-sankaran srikanth-sankaran added this to the 4.32 M1 milestone Feb 14, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 14, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
4ff0cfb 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 14, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
8791127 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 14, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
50692f9 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 14, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
8bea15f 
* Fixes eclipse-jdt#2021
@srikanth-sankaran srikanth-sankaran mentioned this issue Feb 14, 2024
Merged
3 tasks
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 15, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
ab78988 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 15, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
63441fd 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 15, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
f056035 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 16, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
63a1e85 
* Fixes eclipse-jdt#2021
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 18, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
226970e 
* Fixes eclipse-jdt#2021
@mpalat mpalat modified the milestones: 4.32 M1, MilestoneNxt Mar 1, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Mar 5, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
f82e0c5 
* Fixes eclipse-jdt#2021
This was referenced Mar 5, 2024
Closed
Closed
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@srikanth-sankaran
* High degree of code duplication in instanceof pattern code generation
8663079 
* Fixes eclipse-jdt#2021
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@srikanth-sankaran @gayanper
* High degree of code duplication in instanceof pattern code generation
a16bf2e 
* Fixes eclipse-jdt#2021
snjeza pushed a commit to snjeza/eclipse.jdt.core that referenced this issue Oct 21, 2024
@srikanth-sankaran @snjeza
* High degree of code duplication in instanceof pattern code generation
58cec8d 
* Fixes eclipse-jdt#2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-sankaran srikanth-sankaran

Labels
None yet
Projects
None yet
Milestone
MilestoneNxt
Development

Successfully merging a pull request may close this issue.

[Patterns] Cumulative fixes for various problems srikanth-sankaran/eclipse.jdt.core
2 participants
@mpalat @srikanth-sankaran