Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patterns][internal] It doesn't make sense for org.eclipse.jdt.internal.compiler.ast.RecordPattern to extend TypePattern #2043

Closed
srikanth-sankaran opened this issue Feb 18, 2024 · 0 comments · Fixed by #2011
Closed

[Patterns][internal] It doesn't make sense for org.eclipse.jdt.internal.compiler.ast.RecordPattern to extend TypePattern #2043

srikanth-sankaran opened this issue Feb 18, 2024 · 0 comments · Fixed by #2011
Assignees
@srikanth-sankaran
Milestone
MilestoneNxt

Comments

@srikanth-sankaran
Copy link
Contributor

srikanth-sankaran commented Feb 18, 2024 •
edited
Loading

There is no behavior or state that RecordPattern inherits from TypePattern that cannot be hoisted upto Pattern the grand parent class.

In fact it inherits state that has no relevance (e.g: local) that results in dead code at various places.

It would be cleaner to rewire RecordPattern to extend Pattern
@srikanth-sankaran srikanth-sankaran self-assigned this Feb 18, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Feb 18, 2024
@srikanth-sankaran
* Rewire RecordPattern to extend Pattern rather than TypePattern
4538cfb 
* Fixes eclipse-jdt#2043
@srikanth-sankaran srikanth-sankaran mentioned this issue Feb 18, 2024
Merged
3 tasks
@srikanth-sankaran srikanth-sankaran added this to the 4.32 M1 milestone Feb 18, 2024
@mpalat mpalat modified the milestones: 4.32 M1, MilestoneNxt Mar 1, 2024
srikanth-sankaran added a commit to srikanth-sankaran/eclipse.jdt.core that referenced this issue Mar 5, 2024
@srikanth-sankaran
* Rewire RecordPattern to extend Pattern rather than TypePattern
55da231 
* Fixes eclipse-jdt#2043
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@srikanth-sankaran
* Rewire RecordPattern to extend Pattern rather than TypePattern
724a0a2 
* Fixes eclipse-jdt#2043
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this issue Sep 7, 2024
@srikanth-sankaran @gayanper
* Rewire RecordPattern to extend Pattern rather than TypePattern
bc411df 
* Fixes eclipse-jdt#2043
snjeza pushed a commit to snjeza/eclipse.jdt.core that referenced this issue Oct 21, 2024
@srikanth-sankaran @snjeza
* Rewire RecordPattern to extend Pattern rather than TypePattern
e467427 
* Fixes eclipse-jdt#2043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-sankaran srikanth-sankaran

Labels
None yet
Projects
None yet
Milestone
MilestoneNxt
Development

Successfully merging a pull request may close this issue.

[Patterns] Cumulative fixes for various problems srikanth-sankaran/eclipse.jdt.core
2 participants
@mpalat @srikanth-sankaran