StackOverflowException in XLargeTest#test011()

[jarthana]

Fixes #1171

What it does

How to test

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[jarthana]

This is till a WIP, but revealed few more issues with instanceof pattern and BinaryExpression. For e.g., the following code:

  public static void foo(String a) {
	  if ( "" + (a instanceof String s0) != null) {
		  System.out.println(s0);
	  }
  }

Without the patch, we report about s0 not being resolved. With the patch that error goes away, but then we report s0 not being initialized.

I am not an expert in this area, but I tend to think if this is because we always create conditional flow for an InstanceOfExpression.Should we recognize that the effective type for this expression is String and do it differently. I would like to hear from the expert (@stephan-herrmann) on what we should do here.

[srikanth-sankaran]

This PR can be closed as the problem has been fixed by #2011 and is no longer reproducible on master