Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven artifact org.eclipse.jdt.annotation has wrong Maven model version in pom #1500

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

stephan-herrmann
Copy link
Contributor

fixes #1416 by bumping up version although semantically nothing changed

What it does

Bump up version to trigger re-deployment after the fix in eclipse-platform/eclipse.platform#180

How to test

Need to wait for the 2023-12 release to appear on maven central (latest snapshot at https://repo.eclipse.org/service/local/repo_groups/eclipse/content/org/eclipse/jdt/org.eclipse.jdt.annotation/2.2.700-SNAPSHOT/org.eclipse.jdt.annotation-2.2.700-20231019.003952-1.pom already shows the correct maven model version).

Author checklist

in pom

fixes eclipse-jdt#1416 by bumping up version although semantically nothing changed
@stephan-herrmann stephan-herrmann merged commit d1cf644 into eclipse-jdt:master Oct 29, 2023
7 checks passed
@stephan-herrmann stephan-herrmann deleted the issue1416 branch October 29, 2023 10:39
iloveeclipse added a commit to iloveeclipse/eclipse.jdt that referenced this pull request Oct 30, 2023
iloveeclipse added a commit to eclipse-jdt/eclipse.jdt that referenced this pull request Oct 30, 2023
@iloveeclipse
Copy link
Member

iloveeclipse commented Oct 30, 2023

@stephan-herrmann : please next time touch the feature too, to avoid SDK build errors.
See eclipse-platform/eclipse.platform.releng.aggregator#1486

@stephan-herrmann
Copy link
Contributor Author

stephan-herrmann commented Oct 30, 2023

@stephan-herrmann : please next time touch the feature too, to avoid SDK build errors. See eclipse-platform/eclipse.platform.releng.aggregator#1486

Sorry, I wasn't aware that the feature uses explicit version. I'll try to remember this.

And, oops, it's of course the fact that the feature includes 2 versions of this bundle, which forces us to specify versions...

robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
…on in pom (eclipse-jdt#1500)

fixes eclipse-jdt#1416 by bumping up version although semantically nothing changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven artifact org.eclipse.jdt.annotation has wrong Maven model version in pom
2 participants