IrritantSet needs unsigned right shift for GROUP4 and higher #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
pushed a commit
to mickaelistria/eclipse.jdt.core
that referenced
this pull request
Feb 16, 2024
…-jdt#2029) fixes eclipse-jdt#2006 * Apply the correct shift operator * Add a test which will start running once IrritantSet.GROUP4 is enabled in JDT
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…-jdt#2029) fixes eclipse-jdt#2006 * Apply the correct shift operator * Add a test which will start running once IrritantSet.GROUP4 is enabled in JDT
gayanper
pushed a commit
to gayanper/eclipse.jdt.core
that referenced
this pull request
Sep 7, 2024
…-jdt#2029) fixes eclipse-jdt#2006 * Apply the correct shift operator * Add a test which will start running once IrritantSet.GROUP4 is enabled in JDT
snjeza
pushed a commit
to snjeza/eclipse.jdt.core
that referenced
this pull request
Oct 21, 2024
…-jdt#2029) fixes eclipse-jdt#2006 * Apply the correct shift operator * Add a test which will start running once IrritantSet.GROUP4 is enabled in JDT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2006
To watch the effect: run the test against a tweaked IrritantSet.java: