Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jclMin1.8.jar is not complete for 1.8 JLS target tests #3227

Merged
merged 1 commit into from
Nov 3, 2024
Merged

jclMin1.8.jar is not complete for 1.8 JLS target tests #3227

merged 1 commit into from
Nov 3, 2024

Conversation

stephan-herrmann
Copy link
Contributor

@stephan-herrmann stephan-herrmann commented Nov 3, 2024 •
edited
Loading

  • update jclMin1.8
  • also fixes NullAnnotationModelTests.testBug565246 error reporting

Change of strategy:

  • DONOT update jclMin1.8 like this, it would affect too many tests
  • Instead adjust the test to use a JCL that has the required types
    • as this creates a JPMS conflict, use patch-module to resolve that

Fixes #2756

@stephan-herrmann
jclMin1.8.jar is not complete for 1.8 JLS target tests
24ddf6f 
+ DONOT update jclMin1.8 like this, it would affect too many tests
+ Instead adjust the test to use a JCL that has the required types
  - as this creates a JPMS conflict, use patch-module to resolve that
@stephan-herrmann stephan-herrmann merged commit 8eecfe9 into eclipse-jdt:master Nov 3, 2024
10 checks passed
@stephan-herrmann stephan-herrmann deleted the issue2756 branch November 3, 2024 23:13
@akurtakov akurtakov mentioned this pull request Nov 20, 2024
Merged
fedejeanne added a commit to fedejeanne/eclipse.jdt.core that referenced this pull request Nov 21, 2024
@fedejeanne
Bring back a simpler (cheaper) approach to BoundSet::incorporate ecli…
30aa050 
…pse-jdt#3227

This simple approach was faster than the new one but it didn't cover
some very specific use cases, which is why the newer and more complex
(slower) approach was introduced. This commit brings back the older,
simpler, approach and falls back to the newer, more expensive, approach
only when necessary.

Fixes eclipse-jdt#3327
fedejeanne added a commit to fedejeanne/eclipse.jdt.core that referenced this pull request Nov 21, 2024
@fedejeanne
Bring back a simpler (cheaper) approach to BoundSet::incorporate ecli…
fae1ea3 
…pse-jdt#3227

This simple approach was faster than the new one but it didn't cover
some very specific use cases, which is why the newer and more complex
(slower) approach was introduced. This commit brings back the older,
simpler, approach and falls back to the newer, more expensive, approach
only when necessary.

Reduce the visibility of BoundSet::allSuperPairsWithCommonGenericType
from protected to private too.

Fixes eclipse-jdt#3327
fedejeanne added a commit to fedejeanne/eclipse.jdt.core that referenced this pull request Nov 21, 2024
@fedejeanne
Bring back a simpler (cheaper) approach to BoundSet::incorporate ecli…
e6ad65c 
…pse-jdt#3227

This simple approach was faster than the new one but it didn't cover
some very specific use cases, which is why the newer and more complex
(slower) approach was introduced. This commit brings back the older,
simpler, approach and falls back to the newer, more expensive, approach
only when necessary.

Reduce the visibility of BoundSet::allSuperPairsWithCommonGenericType
from protected to private too.

Fixes eclipse-jdt#3327
fedejeanne added a commit to fedejeanne/eclipse.jdt.core that referenced this pull request Nov 25, 2024
@fedejeanne
Bring back a simpler (cheaper) approach to BoundSet::incorporate ecli…
62d2b99 
…pse-jdt#3227

This simple approach was faster than the new one but it didn't cover
some very specific use cases, which is why the newer and more complex
(slower) approach was introduced. This commit brings back the older,
simpler, approach and falls back to the newer, more expensive, approach
only when necessary.

Reduce the visibility of BoundSet::allSuperPairsWithCommonGenericType
from protected to private too.

Fixes eclipse-jdt#3327
fedejeanne added a commit to fedejeanne/eclipse.jdt.core that referenced this pull request Nov 27, 2024
@fedejeanne
Bring back a simpler (cheaper) approach to BoundSet::incorporate ecli…
4fdd139 
…pse-jdt#3227

This simple approach was faster than the new one but it didn't cover
some very specific use cases, which is why the newer and more complex
(slower) approach was introduced. This commit brings back the older,
simpler, approach and falls back to the newer, more expensive, approach
only when necessary.

Reduce the visibility of BoundSet::allSuperPairsWithCommonGenericType
from protected to private too.

Fixes eclipse-jdt#3327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jclMin1.8.jar is not complete for 1.8 JLS target tests
1 participant
@stephan-herrmann