Primitives in record component type patterns to be enabled with null check #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalat
changed the title
1 task
jarthana
added a commit
that referenced
this pull request
Dec 6, 2024
* Remove nolonger support converterJclMin (#3332) Versions older than 1.8 are not supported and thus shouldn't be needed anymore. * Fix and enable Java50Tests#testMissingRequiredBinaries * Version bump(s) for 4.35 stream * Test failures in I-Builds due to less diagnostics being emitted (#3357) * Fixes #3356 * Textual problem indicator goes wild with lamda (#3358) * jclMin23: ignore missing serializable problem "The serializable class Long does not declare a static final serialVersionUID field of type" * Fix FieldLocator and MethodLocator to support local/anonymous classes (#3314) - Fix FieldLocator.reportDeclaration() and MethodLocator.reportDeclaration() to find the anonymous or local type for the declaration rather than to return - add new tests to JavaSearchBugsTests - fixes #3308 * Codegen Primitives in record comonent patterns to be enabled with null check before calling accessor(#3361) Before generating an invoke of accessor of a record component, do a null check if primitive conversions are involved. * java.lang.StackOverflowError during "Requesting Java AST from selection" (#3373) + resilience: avoid accepting a sourceType being completed already + better hiding of modules seen via the classpath Fixes #3273 * Add NoSuchFieldError to converterJclMin18 (#3368) Add NoSuchFieldError to converterJclMin18 + build the jar + avoid new warning Enable couple of tests fixed by this. --------- Co-authored-by: Stephan Herrmann <stephan.herrmann@berlin.de> * Incorrect control flow analysis causes statement subsequent to a switch statement to be flagged unreachable under some circumstances(#3377) * Fixes #3376 * Remove unused api problem filter * Update tycho build to 4.0.10 * Completion for unimported types doesn't work. - use MissingTypesGuesser to select all missing types and offer their completion - Fixes #1502 * [Enhanced Switch] Wrong error message: Cannot switch on a value of type Integer... at levels that don't support enhanced switch (#3380) * Fixes #3379 --------- Co-authored-by: Александър Куртаков <akurtakov@gmail.com> Co-authored-by: Eclipse JDT Bot <jdt-bot@eclipse.org> Co-authored-by: Srikanth Sankaran <131454720+srikanth-sankaran@users.noreply.github.com> Co-authored-by: Jörg Kubitz <jkubitz-eclipse@gmx.de> Co-authored-by: Jeff Johnston <jjohnstn@redhat.com> Co-authored-by: Manoj N Palat <manoj.palat@in.ibm.com> Co-authored-by: Stephan Herrmann <stephan.herrmann@berlin.de> Co-authored-by: Snjeza <snjezana.peco@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When primitives in type patterns are present, before calling the accessor a null check needs to be done since null does not match the primitive anyway.
How to test
Author checklist