[24] don't request access to enclosing class if it's never used #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephan-herrmann
force-pushed
the
issue3194_reopened
branch
from
4ae6fb9 to
b6980e6
Compare
laeubi
reviewed
Dec 16, 2024
Jenkinsfile
Outdated
| @@ -33,7 +33,7 @@ pipeline { | |||
| mvn -U clean verify --batch-mode --fail-at-end -Dmaven.repo.local=$WORKSPACE/.m2/repository \ | |||
| -Ptest-on-javase-24 -Pbree-libs -Papi-check -Pjavadoc -Pp2-repo \ | |||
| -Dmaven.test.failure.ignore=true \ | |||
| -Dcompare-version-with-baselines.skip=false \ | |||
| -Dcompare-version-with-baselines.skip=true \ | |||
There was a problem hiding this comment.
Please make sure BETA_24 is in sync with master instead of skipping baseline checks as otherwise you probably see other issues later on.
There was a problem hiding this comment.
we're going in circles.
Fixes after re-opening: + essentially revert previous change + replace with specific detection wrt local type alloc in static context Fixes eclipse-jdt#3194
+ additional test Fixes eclipse-jdt#3194
stephan-herrmann
force-pushed
the
issue3194_reopened
branch
from
ab85b16 to
a6921a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes after re-opening:
Fixes #3194