[performance] optimized ClasspathDirectory #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* java.io.File.list() returns null if the file is not a directory, so File.isDirectory() is not needed. * use ConcurrentHashMap instead of Hashtable * avoid rawtypes ClasspathDirectory.directoryList(String) is a hotspot for example during NullTypeAnnotationTest
|
This PR reduces NullTypeAnnotationTest from 102 sec to 99 sec |
szarnekow
reviewed
Dec 10, 2024
| @@ -360,7 +358,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) { | |||
| @Override | |||
| public void reset() { | |||
| super.reset(); | |||
| this.directoryCache = new Hashtable(11); | |||
| this.directoryCache.clear(); | |||
There was a problem hiding this comment.
Do you know why teh secondaryTypes are not cleared?
There was a problem hiding this comment.
I also wondered about that. i decided to only make a performance change here keeping logic as is.
jukzi
force-pushed
the
ClasspathDirectory
branch
from
f99d971 to
9c059ca
Compare
|
@jukzi There is an issue in this code: raised issue #3445 for the same. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClasspathDirectory.directoryList(String) is a hotspot for example during NullTypeAnnotationTest