[performance] determineIfOnClasspath with last project used #3470 #3475
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/JavaModelManager.java
Show resolved
Hide resolved
iloveeclipse
requested changes
Dec 18, 2024
org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/JavaModelManager.java
Show resolved
Hide resolved
jukzi
force-pushed
the
determineIfOnClasspath_1
branch
2 times, most recently
from
3d1e4f0 to
8697e97
Compare
…dt#3470 Instead of randomly looping over all projects try the last successful first. Tested by JavaModelTests.testCreatePkgHandleInDifferentProject() eclipse-jdt#3470
jukzi
force-pushed
the
determineIfOnClasspath_1
branch
from
8697e97 to
d827804
Compare
iloveeclipse
approved these changes
Dec 18, 2024
I did not test it beside junit yet, as i could not reproduce it yet. It's just that the stacktrace clearly indicated that 1000 unrelated projects might have been searched. |
|
Since also other reporters like https://bugs.eclipse.org/bugs/show_bug.cgi?id=541040#c7 observed that the perfromance problem can not be deterministically reproduced i think its best to submit even without real world benchmark and keep monitoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of randomly looping over all projects try the last successful first.
Tested by JavaModelTests.testCreatePkgHandleInDifferentProject()
#3470