Equinox deletes some JRE1.1 profile #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveeclipse
reviewed
Apr 9, 2024
|
@iloveeclipse I have updated the PR. |
snjeza
force-pushed
the
issue-424
branch
3 times, most recently
from
d54e319 to
47046d5
Compare
snjeza
changed the title
snjeza
force-pushed
the
issue-424
branch
2 times, most recently
from
9c804ac to
770b4c9
Compare
snjeza
changed the title
|
@rgrunber @iloveeclipse Could you, please, review the PR again? |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
rgrunber
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
LGTM. I tested by adding something like Arrays.asList(JavaRuntime.getExecutionEnvironmentsManager().getExecutionEnvironments()).stream().anyMatch(ee -> "JRE-1.1".equals(ee.getId())); and confirm it's false with this change.
If @iloveeclipse is fine with it, I'd say we should merge.
HannesWell
added a commit
to HannesWell/m2e-core
that referenced
this pull request
Apr 11, 2024
With [1] and [2] support for 'JRE-1.1' execution environment is removed from JDT respectively Equinox. Therefore M2E has no need anymore to support this exotic (and probably hardly used) execution environment. [1] - eclipse-equinox/equinox#571 [2] - eclipse-jdt/eclipse.jdt.debug#425
HannesWell
added a commit
to HannesWell/m2e-core
that referenced
this pull request
Apr 11, 2024
With [1] and [2] support for 'JRE-1.1' execution environment is removed from JDT respectively Equinox. Therefore M2E has no need anymore to support this exotic (and probably hardly used) execution environment. [1] - eclipse-equinox/equinox#571 [2] - eclipse-jdt/eclipse.jdt.debug#425
HannesWell
added a commit
to eclipse-m2e/m2e-core
that referenced
this pull request
Apr 11, 2024
With [1] and [2] support for 'JRE-1.1' execution environment is removed from JDT respectively Equinox. Therefore M2E has no need anymore to support this exotic (and probably hardly used) execution environment. [1] - eclipse-equinox/equinox#571 [2] - eclipse-jdt/eclipse.jdt.debug#425
This was referenced Apr 15, 2024
kysmith-csg
pushed a commit
to kysmith-csg/m2e-core
that referenced
this pull request
Jun 3, 2024
With [1] and [2] support for 'JRE-1.1' execution environment is removed from JDT respectively Equinox. Therefore M2E has no need anymore to support this exotic (and probably hardly used) execution environment. [1] - eclipse-equinox/equinox#571 [2] - eclipse-jdt/eclipse.jdt.debug#425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #424
How to test
See eclipse-m2e/m2e-core#1735
Author checklist