Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StringBuffer/StringBuilder to text block to handle indexOf(x,y) #1904

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Jan 6, 2025

What it does

See issue.

How to test

See issue or test modifications.

Author checklist

- fix StringConcatToTextBlockFixCore.ChangeStringBufferToTextBlock
  to not assume indexOf() has just one parameter
- modify CleanUpTest15 to add new scenario
- fixes eclipse-jdt#1903
@jjohnstn jjohnstn added the bug Something isn't working label Jan 6, 2025
@jjohnstn jjohnstn added this to the 4.35 M2 milestone Jan 6, 2025
@jjohnstn jjohnstn self-assigned this Jan 6, 2025
@jjohnstn
Copy link
Contributor Author

jjohnstn commented Jan 7, 2025

Failing tests are due to a JDT Core change.

@jjohnstn jjohnstn merged commit cac5317 into eclipse-jdt:master Jan 7, 2025
7 of 10 checks passed
@jjohnstn jjohnstn deleted the textblockindex2 branch January 7, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert from StringBuilder/StringBuffer to text block does not handle indexOf with 2 arguments
1 participant