Fix CompletionContextTests0123 inside JavacConverter

[robstryker]

This is a proof of concept of adding a specific erroneous / invalid node to the dom tree in all cases, not just completion, and seeing what regressions we get.

[mickaelistria]

This seems to fix 2 tests.

[robstryker]

#1110 had no discernably different result.

Using the following script:

#!/bin/sh

curl -H 'Cache-Control: no-cache' --compressed https://ci.eclipse.org/ls/job/jdt-core-incubator/job/PR-$1/lastSuccessfulBuild/testReport/api/xml | xmllint --xpath '/testResult/suite/case[status != "PASSED"]/*[name() = "className" or name() = "name"]/text()' - | sed 'N; s/\n/ /' - | sort > /home/rob/scripts/jdt_pr_data/pr.txt

curl -H 'Cache-Control: no-cache' --compressed https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/lastSuccessfulBuild/testReport/api/xml | xmllint --xpath '/testResult/suite/case[status != "PASSED"]/*[name() = "className" or name() = "name"]/text()' - | sed 'N; s/\n/ /' - | sort > /home/rob/scripts/jdt_pr_data/baseline.txt

diff /home/rob/scripts/jdt_pr_data/pr.txt /home/rob/scripts/jdt_pr_data/baseline.txt

wc -l  ~/scripts/jdt_pr_data/baseline.txt
wc -l  ~/scripts/jdt_pr_data/pr.txt

I noticed the following output:

2754 /home/rob/scripts/jdt_pr_data/baseline.txt
2687 /home/rob/scripts/jdt_pr_data/pr.txt

[robstryker]

Nevermind. My script didn't account for "FIXED" status.

Yes, fixes 2. Looks good to me. Let me know if I should merge.

[mickaelistria]

Feel free to merge it ASAP.

[mickaelistria]

Maybe add something like res.setFlags(res.getFlags() | ASTNode.MALFORMED)

[robstryker]

This broke dom-with-javac somehow. Looking into it.